From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 80F8C469719 for ; Tue, 10 Mar 2020 14:23:53 +0300 (MSK) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) From: Serge Petrenko In-Reply-To: <2e299aec-23c8-400d-8daf-3f7f8d015c48@tarantool.org> Date: Tue, 10 Mar 2020 14:23:51 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <19BC751F-D18D-4942-A67F-EECE82FCE78D@tarantool.org> References: <20200305113600.65203-1-sergepetrenko@tarantool.org> <2e299aec-23c8-400d-8daf-3f7f8d015c48@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org > 9 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2020 =D0=B3., =D0=B2 01:16, Vladislav = Shpilevoy =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0= =D0=BB(=D0=B0): >=20 > Hi! Thanks for the fixes! >=20 > I think you can just merge the second commit into the > first one. If you don't want, then prepend that commit's > title with a subsystem name. >=20 > xrow: use bit_count_u32() for replica_id filter >=20 > instead of >=20 > use bit_count_u32() for replica_id filter >=20 Hi! Changed the commit title. `use bit_count_u32() for replica_id filter` -> `xrow: use = bit_count_u32() for replica_id filter` > After that LGTM. -- Serge Petrenko sergepetrenko@tarantool.org