From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EBACB6FC8F; Thu, 25 Mar 2021 22:59:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EBACB6FC8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616702396; bh=X1oVUStyyB/fWOh/xvHxliDFpgcc9Bb9I4eRJMON2wM=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mcgRuQtAVy/V/gAUs6YDfFPYbgdf1EUAnmBz95o04i6IPF7E/5yxC2i3QuMCdQUIA JbRLF8UWa6/FOEmN4Cic61FuqYLZ3GW9FZR5RMNdU5AZcJNey9p0ciOweBEn2jywmv IG0+fwsrLj3eV8AHGm3p/Wgpq1AMwpUdtlm3YeoI= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3D16B6FC8F for ; Thu, 25 Mar 2021 22:59:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3D16B6FC8F Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lPW94-0006i4-L3; Thu, 25 Mar 2021 22:59:54 +0300 To: Cyrill Gorcunov References: <20210324163759.1900553-1-gorcunov@gmail.com> <20210324163759.1900553-2-gorcunov@gmail.com> <8faa2e1e-c198-832d-d527-1acf2280720d@tarantool.org> Message-ID: <19605c5e-e96c-8580-6309-3b0e58df8c01@tarantool.org> Date: Thu, 25 Mar 2021 20:59:53 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9064ADF4728AA0EE922675D89A18E042B1EBC993A8274C79D182A05F538085040DBCF91823F8290CBC58AFBF0FC553BF31EBDAE9F60CB8F385EB79C51448C241D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77806F8AEFB2C8BE8EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378B6D775AC58C227F8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D1FA7E735227B0D8F26F8D18EA6631C41A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3BEC81E4AEBD6D2BF117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73542F54486E6D6388DC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A56D7DBDD6A4C226A9D29432AC7225DD89519F7F117D3924A7D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A533D6DF7731C6647DD6EDF5010B94BB5E45E9146F425D9D6BCAAD27D3E0C6922CEC2BBDC0CBB5851D7E09C32AA3244C07A21544736AD830236F83FE703626AF6C24832127668422FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAhf4qom3xogMg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382278C5A24E9D098CE8ABFEB8D890C2EBB03841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 1/3] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" > Here is an update on top. I see a few red tests on our github actions > but still trying to figure out what is happening, since I've been > passing the tests on my local instance > --- > diff --git a/src/box/box.cc b/src/box/box.cc > index a269f7357..ab298d223 100644 > --- a/src/box/box.cc > +++ b/src/box/box.cc > @@ -774,10 +774,18 @@ box_check_wal_queue_max_size(void) > static double > box_check_wal_cleanup_delay(void) > { > + const double MAX_TIMEOUT = TIMEOUT_INFINITY; > + const double MIN_TIMEOUT = 0.001; I am going to repeat it here from what I said verbally and in the chat - don't restrict the timeout. We never restrict any timeouts. TIMEOUT_INFINITY is not literally double inf value. It is just some huge but valid double value. User in his code can have a bigger definition of what is infinity. The same with the min. Why do you limit it from below? I don't see a single reason for doing so. Only reasons against that - it is inconsistent with the other timeouts we have, and might conflict with how each particular user understand the "minimal" timeout. Instead, I asked you to check what if I pass Lua's math.huge value. AFAIK, it is not some finite double value, and it might break something. > + > double value = cfg_getd("wal_cleanup_delay"); > - if (value < 0) { > + if (value < 0 || (value != 0 && value < MIN_TIMEOUT) || > + value > MAX_TIMEOUT) { > + char message[64]; > + snprintf(message, sizeof(message), > + "the value must be 0 or in range [%g; %g]", > + MIN_TIMEOUT, TIMEOUT_INFINITY); > diag_set(ClientError, ER_CFG, "wal_cleanup_delay", > - "the value must be >= 0"); > + message); > return -1; > } >