From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 85EAE46970E for ; Wed, 18 Dec 2019 10:49:14 +0300 (MSK) From: Georgy Kirichenko Date: Wed, 18 Dec 2019 10:49:12 +0300 Message-ID: <1947329.0EtQL3PaDb@localhost> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart11068717.GojGjYiWkl"; micalg="pgp-sha256"; protocol="application/pgp-signature" Subject: Re: [Tarantool-patches] [PATCH 0/5] introduce anonymous replicas List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergepetrenko Cc: tarantool-patches@dev.tarantool.org --nextPart11068717.GojGjYiWkl Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi! Thank you for the patch set, good approach and overall it looks good to be merged. And there alos some points I would like to point. Please consider what should happen if any other instance tries to connect to an anonymous replica. I think we could enable such replication if a connecting replica is anonymous to, however, this should be an object of a different issue so we could disable such behavior right now. At least we should handle replica_id = 0 while replication. The last point I would like to mention is that a test with replication from an anonymous replica could be included. On Sunday, 15 December 2019 23:56:14 MSK sergepetrenko wrote: > Serge Petrenko (3): > box: update comment describing join protocol > replication: do not decode replicaset uuid when processing a subscribe > applier: split join processing into two stages > > sergepetrenko (2): > vclock: ignore 0th component in comparisons. > replication: introduce anonymous replica. > > src/box/applier.cc | 119 ++++++++++++-- > src/box/applier.h | 4 + > src/box/box.cc | 278 ++++++++++++++++++++++++++++++-- > src/box/box.h | 11 +- > src/box/iproto.cc | 16 +- > src/box/iproto_constants.h | 6 + > src/box/lua/cfg.cc | 14 +- > src/box/lua/info.c | 4 +- > src/box/lua/load_cfg.lua | 4 + > src/box/recovery.cc | 7 +- > src/box/relay.cc | 32 +++- > src/box/replication.cc | 41 ++++- > src/box/replication.h | 24 +++ > src/box/vclock.h | 7 + > src/box/wal.c | 4 + > src/box/xrow.c | 47 +++++- > src/box/xrow.h | 68 ++++++-- > test/app-tap/init_script.result | 49 +++--- > test/box/admin.result | 2 + > test/box/cfg.result | 4 + > test/replication/anon.lua | 13 ++ > test/replication/anon.result | 259 +++++++++++++++++++++++++++++ > test/replication/anon.test.lua | 89 ++++++++++ > test/replication/suite.cfg | 1 + > test/unit/vclock.cc | 8 +- > 25 files changed, 1022 insertions(+), 89 deletions(-) > create mode 100644 test/replication/anon.lua > create mode 100644 test/replication/anon.result > create mode 100644 test/replication/anon.test.lua --nextPart11068717.GojGjYiWkl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEECXG+Yw5ArYcP8x5wDVHWG5PoUw4FAl352fgACgkQDVHWG5Po Uw7fnQf+PPduFApyUtA5mHxf0Z31X72STZkdrbvf4q8RhbOs/uzQkGsmZHjJ9I8D H+t8koGPeE8iAzaTlr3j8rhKXMilaZkW/pgm9dE7V/Ix6FVEaECFrg8idtU9K0QY CkG1yGBRwbc+HclFjc4olqHw5pXp6xo/stvxRm+y1z+iEEakyGAoq08xVL0KutpL 6hCAR6wurEL+bT7Uo0foX+xZyx/2ogyzNDiD200PBJ2zfk3LlPDd374vJslxae5Y A6qWOAByoPsdG4DQMqHgFjftg6gv6fbA37lCS82k5Wu86xdddQdSEgvyZbf/Scc8 OYOauV4Kj5jC+B5w8HPFKtTBVLjtog== =YW/V -----END PGP SIGNATURE----- --nextPart11068717.GojGjYiWkl--