From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 03D51170409F; Tue, 7 Apr 2026 13:16:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 03D51170409F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1775556963; bh=mIAKzmIINS86pGncle9fNI4uw7iXE9T+PHnNvwwIlmw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=DmzrLtZvImoWonJXl7ca9uet/9Tf9eD7rJKoBB4okdRctJagJgsRD9M+Ab3PGyBGe WYXx3sbQjbHe+rYWGalPezL0f9LV7osNvkktLOZH7BrAYgQWpdkNgDiZXm/nOlIBWk QwojkYKgCXtU+9HAg76zsOh/9lihAu6eVpy/Eq+Q= Received: from send220.i.mail.ru (send220.i.mail.ru [95.163.59.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 777F01704094 for ; Tue, 7 Apr 2026 13:16:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 777F01704094 Received: by exim-smtp-5d968d944d-kv7cm with esmtpa (envelope-from ) id 1wA3TU-0000000096C-0yeJ; Tue, 07 Apr 2026 13:16:00 +0300 Content-Type: multipart/alternative; boundary="------------Os0C4VvbJAhQgLJSfh0ogzIa" Message-ID: <18e9c5f1-3aa7-4df9-8119-7aaedb54307d@tarantool.org> Date: Tue, 7 Apr 2026 13:15:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <20260406130407.21995-1-skaplun@tarantool.org> Content-Language: en-US In-Reply-To: <20260406130407.21995-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD931A1A7E579CE6E95EB64011DCAEE3F6DC167A0B0D542F667182A05F5380850406B6DFEF3F09014BE3DE06ABAFEAF67058D3C8DF4534ABA9B5F39AB8AB2DAD2C0DE81258B7D5E2227 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FBCED7D376B82B5EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376A27C8034CCD05E58638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2A4585FBA53E646252E070BE324C7D3C4E0C7F9F153A3B839F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249F459A8243F1D1D44CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C05A64D9A1E9CA65708941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C361DD96311B40C2D435872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A538BB49F75EDFDD1E5002B1117B3ED696330A457E06D2151D72305013E4AE841E823CB91A9FED034534781492E4B8EEAD09F854029C6BD0DABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65977EB392A6B5243021C3769E6881A40EB7211007278641828979BAA64C11FD587288452CB5171D76BB8341EE9D5BE9A0A9719A7CE457621720EA7EFF957549D2AA17EAA0ADC46960F8CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVajF1spCY9aaLetkdNAaMw8= X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE23A3D6DE2FB7B7702E9006103AABD57338CE64F0C6783FD9FEF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] cmake: fixup tests build for old CMake X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------Os0C4VvbJAhQgLJSfh0ogzIa Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, Thanks for the patch! LGTM Sergey On 4/6/26 16:04, Sergey Kaplun wrote: > This patch is a follow-up to the commit > 1e5887d884be92c24ebd7c9db0a9b21ea366a0b5 ("FFI: Avoid dangling > cts->L."). The `target_link_options()` feature is introduced in CMake > 3.13. Unfortunately, we have distros in Tarantool's CI with an older > default CMake version. > > This patch workarounds this by the passing `LINK_FLAGS` directly. > --- > > Branch:https://github.com/tarantool/luajit/tree/skaplun/fix-old-cmakes > > test/tarantool-c-tests/CMakeLists.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt > index 3bb20bff..ea553db8 100644 > --- a/test/tarantool-c-tests/CMakeLists.txt > +++ b/test/tarantool-c-tests/CMakeLists.txt > @@ -56,11 +56,11 @@ foreach(test_source ${tests}) > ) > set_target_properties(${exe} PROPERTIES > COMPILE_FLAGS "${TESTS_C_FLAGS}" > + # Allow to call non-static functions via FFI. > + LINK_FLAGS "-rdynamic" > OUTPUT_NAME "${exe}${C_TEST_SUFFIX}" > RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}" > ) > - # Allow to call non-static functions via FFI. > - target_link_options(${exe} PRIVATE "-rdynamic") > target_link_libraries(${exe} libtest ${LUAJIT_LIBRARY}) > add_dependencies(tarantool-c-tests-build ${exe}) > --------------Os0C4VvbJAhQgLJSfh0ogzIa Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

Thanks for the patch! LGTM

Sergey

On 4/6/26 16:04, Sergey Kaplun wrote:
This patch is a follow-up to the commit
1e5887d884be92c24ebd7c9db0a9b21ea366a0b5 ("FFI: Avoid dangling
cts->L."). The `target_link_options()` feature is introduced in CMake
3.13. Unfortunately, we have distros in Tarantool's CI with an older
default CMake version.

This patch workarounds this by the passing `LINK_FLAGS` directly.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/fix-old-cmakes

 test/tarantool-c-tests/CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
index 3bb20bff..ea553db8 100644
--- a/test/tarantool-c-tests/CMakeLists.txt
+++ b/test/tarantool-c-tests/CMakeLists.txt
@@ -56,11 +56,11 @@ foreach(test_source ${tests})
   )
   set_target_properties(${exe} PROPERTIES
     COMPILE_FLAGS "${TESTS_C_FLAGS}"
+    # Allow to call non-static functions via FFI.
+    LINK_FLAGS "-rdynamic"
     OUTPUT_NAME "${exe}${C_TEST_SUFFIX}"
     RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}"
   )
-  # Allow to call non-static functions via FFI.
-  target_link_options(${exe} PRIVATE "-rdynamic")
   target_link_libraries(${exe} libtest ${LUAJIT_LIBRARY})
   add_dependencies(tarantool-c-tests-build ${exe})
--------------Os0C4VvbJAhQgLJSfh0ogzIa--