From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 6A7D144643A
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 29 Sep 2020 01:21:14 +0300 (MSK)
References: <cover.1600955781.git.tsafin@tarantool.org>
 <96922008cb146eaa04cb727472eda3e71f2e7bc8.1600955781.git.tsafin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <185c95b5-edc6-10d0-50c0-ba7c086fc97a@tarantool.org>
Date: Tue, 29 Sep 2020 00:21:12 +0200
MIME-Version: 1.0
In-Reply-To: <96922008cb146eaa04cb727472eda3e71f2e7bc8.1600955781.git.tsafin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2.X 4/7] module api:
 luaL_register_module & luaL_register_type
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Timur Safin <tsafin@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org>, Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thanks for the patch!

See 2 comments below.

On 24.09.2020 19:00, Timur Safin wrote:
> Exporting `luaL_register_module` & `luaL_register_type`
> functions as they needed for external merger
> 
> diff --git a/src/lua/utils.h b/src/lua/utils.h
> index 7639cd64a..9b1fe7e57 100644
> --- a/src/lua/utils.h
> +++ b/src/lua/utils.h
> @@ -78,6 +78,8 @@ luaL_pushuuid(struct lua_State *L);
>  
>  /** \cond public */
>  
> +struct luaL_Reg;

1. It does not seem to be public. How are users supposed to work with that?
Igor, could you please take a look at this?

If you need it so badly, at least we need a wrapper around luaL_Reg
or we need to expose it and document too. Probably Igor has better ideas.

> +
>  /**
>   * @brief Checks whether a value on the Lua stack is a cdata.
>   *
> @@ -442,6 +444,8 @@ luaL_checkfield(struct lua_State *L, struct luaL_serializer *cfg, int idx,
>  	luaL_convertfield(L, cfg, idx, field);
>  }
>  
> +/** \cond public */
> +
>  void
>  luaL_register_type(struct lua_State *L, const char *type_name,
>  		   const struct luaL_Reg *methods);

2. These newly exported methods don't have a single comment. Why?