From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 10B796E200; Sat, 19 Jun 2021 01:49:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 10B796E200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624056595; bh=YmoX8PNHYbFPfIpXdEpQlrLxocxmUPwyPasVOcxiCxA=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=YQVvtfBi2WqDOpqAJrcaXJLPSxbLH2g2pFAAvoXRs7M4eKU/yXMPyGFtrHOMQQ3Op k2545LF9vllh8IVFI72bmHSOAuaeB0mZ2Zh4JYmiZBHujc+wZhdkWdqKmBpmW655Zo 5uBEdlmdB5cQHBcs+PtOmSLK1I2VrKJybp9YLZDU= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 39E336E200 for ; Sat, 19 Jun 2021 01:49:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 39E336E200 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1luNJ6-0004Vj-Hw; Sat, 19 Jun 2021 01:49:48 +0300 To: Serge Petrenko , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <1819defc-9d99-c3f0-41d1-52955c5af02c@tarantool.org> Date: Sat, 19 Jun 2021 00:49:47 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91C2C07775F13263AD4A2A3BFBC817E640615893838B9A94F00894C459B0CD1B9748892DA012A5CC4A2AA778028ED28581423CBEC9FF1E7EF6C140D91676DDD80 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AD3501B5CE9C42E3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F757A79C3007ACA28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8465A75FA695E0DCDBAA4CB1CC4270328117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BB07C9E286C61B7F975ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831F674C1C9E8807E9363EC326E2DBBB914 X-C1DE0DAB: 0D63561A33F958A5D116F774EB1FE41F19C708E5AAEB0DAEB810580C5402B2EBD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34DA1FE609583D493C0E89C5910CE917701DAF09445E1D23C7BFF80F85178F026FE08359DCE22893941D7E09C32AA3244C7667F919A72C28124270A1C34ED517E0E8FBBEFAE1C4874CFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0Roc5o5ut96Wm6PX0a0CLQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822EBADE4E354FEB398A005FCA5C0B280943841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/7] replication: forbid implicit limbo owner transition X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Nice fixes! See 3 comments below. > diff --git a/src/box/errcode.h b/src/box/errcode.h > index 49aec4bf6..e3943c01d 100644 > --- a/src/box/errcode.h > +++ b/src/box/errcode.h > @@ -278,6 +278,7 @@ struct errcode_record { > /*223 */_(ER_INTERFERING_PROMOTE, "Instance with replica id %u was promoted first") \ > /*224 */_(ER_RAFT_DISABLED, "Elections were turned off while running box.ctl.promote()")\ > /*225 */_(ER_TXN_ROLLBACK, "Transaction was rolled back") \ > + /*226 */_(ER_SYNCHRO_QUEUE_UNCLAIMED, "The synchronous transaction queue doesn't belong to any instance")\ 1. Maybe SYNCHRO -> SYNC? The rationality is that we already have a few ER_SYNC_* about synchro replication. > diff --git a/test/box/error.result b/test/box/error.result > index 062a90399..574521a14 100644 > --- a/test/box/error.result > +++ b/test/box/error.result > @@ -444,6 +444,7 @@ t; > | 223: box.error.INTERFERING_PROMOTE > | 224: box.error.RAFT_DISABLED > | 225: box.error.TXN_ROLLBACK > + | 226: box.error.LIMBO_UNCLAIMED 2. Forgot to update the result file? There is no LIMBO_UNCLAIMED error code. It has a new name. > diff --git a/test/replication/gh-5440-qsync-ro.test.lua b/test/replication/gh-5440-qsync-ro.test.lua > deleted file mode 100644 > index d63ec9c1e..000000000 > --- a/test/replication/gh-5440-qsync-ro.test.lua 3. Please, drop it from suite.cfg too.