From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 90CE4E95FE6; Fri, 11 Oct 2024 17:02:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 90CE4E95FE6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1728655328; bh=cp8+Wcf5oDErPeu8bc6ianFbiNdGfb0w3BBkwGIydJY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=qZtonkbXghR+feIE42RSnc8dF2xAhTB0/x8vw813DufUzZKRF8YJWIbcYgjJAbH4O fU1XLb5/f7h9geIWyf8GIsadyiNHBvZez5HaaX2xXDtJ3ZZF1uH8bzCtvwyE0WO6St S7a7wdPwObOT8P17SzCp4Axq+YCfWIAhOJ/yKU4E= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [95.163.41.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A3EFC5C571C for ; Fri, 11 Oct 2024 17:02:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A3EFC5C571C Received: by exim-smtp-57dbb65494-6727b with esmtpa (envelope-from ) id 1szGDV-0000000068w-2mEa; Fri, 11 Oct 2024 17:02:05 +0300 Content-Type: multipart/alternative; boundary="------------BC890SMFlO68Px0aqTVOPeJp" Message-ID: <17fd3424-51f8-42ed-8c28-143c99876ce7@tarantool.org> Date: Fri, 11 Oct 2024 17:02:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun References: <20240925103656.14771-1-skaplun@tarantool.org> <2486af85-0af6-4073-952c-ce5ce5a86d5c@tarantool.org> Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9B01871A0ED523BBFF2944416096D9CA3AE14DD4C63332AA4182A05F53808504086D96832E69B6DE63DE06ABAFEAF6705BC0704153A18C31A0464B9C45FE61567F14F8599D8FED5CC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70386A6136E33FD82EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378997215BCAA11D778638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88490C74B5ADD6502EEA9110145ECC81AE09404B6B3D2A5E2CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C632EDEA9CD5989A36E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C310DA8F912E8A02C0BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE71F4E386938175FB9731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A582565BD1D642C7D85002B1117B3ED696942B5F15A06B324B250A03108B67251B823CB91A9FED034534781492E4B8EEAD2739D626790C8313BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34A783A638E01A3CDE6ADFDBB0300A888FDB9389769F26836A14BB47A2EE5DB7E10E832D060F6DBA9A1D7E09C32AA3244C17DDBD03E538A9ED77DD89D51EBB77428F675D0AB039F1B9EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMU25eydo6+l0Q9C6trWJww== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140F9FCAB748FC1C1E02EB5D77EF37489D1B8B598F60747C3ED0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Limit CSE for IR_CARG to fix loop optimizations. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------BC890SMFlO68Px0aqTVOPeJp Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey! On 08.10.2024 16:25, Sergey Kaplun wrote: >>> +ffi.cdef[[ >>> + double sin(double, ...); >>> + double cos(double, ...); >> Why do you use sin/cos with wrong function prototypes if you can take >> >> a function with varargs. (printf for example)? > I suppose this hack is well suited for our testing purposes: > 1) We don't need to create custom vararg functions and the corresponding > C libary. > 2) Functions usage is obvious. Also, the vararg part will be silently > ignored. > > Be aware that we need the result of the function's call. > Got it. I would add this as a comment. Feel free to ignore. LGTM --------------BC890SMFlO68Px0aqTVOPeJp Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey!

On 08.10.2024 16:25, Sergey Kaplun wrote:

<snipped>

+ffi.cdef[[
+  double sin(double, ...);
+  double cos(double, ...);

Why do you use sin/cos with wrong function prototypes if you can take

a function with varargs. (printf for example)?

I suppose this hack is well suited for our testing purposes:
1) We don't need to create custom vararg functions and the corresponding
   C libary.
2) Functions usage is obvious. Also, the vararg part will be silently
   ignored.

Be aware that we need the result of the function's call.

Got it. I would add this as a comment. Feel free to ignore.

LGTM

--------------BC890SMFlO68Px0aqTVOPeJp--