From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6FBDE7030D; Mon, 13 Sep 2021 11:52:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6FBDE7030D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1631523162; bh=ULRz1C0F3eFKBxIGBYklDTVsE80EKtoszRPMaml9rFk=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=LdmTTYcXjj0zZ+S7BboxM/J/Ptl1JA4C/ivCdBo8F+xHIUws/to2SHM16Ivtfa456 sRDj1W2tzlNmmmTb1BPElO8v/HLhNI/1MgR9A0F5G0U7zCuWAJHt1cBDfG1aDVOw72 UctYwsehlRUfsiAUulWVeTgbQbundYbQB7S1d+1E= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0B8CE7030D for ; Mon, 13 Sep 2021 11:52:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0B8CE7030D Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1mPhhg-00017j-Bj; Mon, 13 Sep 2021 11:52:40 +0300 To: Cyrill Gorcunov , Vladislav Shpilevoy Cc: tml References: <20210910152910.607398-1-gorcunov@gmail.com> <20210910152910.607398-3-gorcunov@gmail.com> Message-ID: <17e39694-2f8b-da02-6009-c97ec46e8609@tarantool.org> Date: Mon, 13 Sep 2021 11:52:39 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91AE02D33A9C88A2FBA0FFC16CEFBFC694531AE86BFF036DF00894C459B0CD1B940BB09F0E7BB70D46138CA15C5467524B1297A869713209A206BCEC6F5B8A356 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A4C4638C9DDF45FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375B4C42A189C515578638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B07E3C62DA030896D42F43BA963FC29B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E57F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6F7FD1A3A8AE6177F089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5F33FFD9CBA3FA33F8878A7D7859E45CAA10A51C40D6CB210D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346B1FF97F6D0959A2A41D7FF57DC4DC5D1ABE96A56B698D2D536F5654AE1A8F8A2C3C5729F034056B1D7E09C32AA3244CB3E32A1CCA88FD811AA1E3344140EF951E098CBE561D6343FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojEltUM+pNOWNJ4HwVEl2llg== X-Mailru-Sender: 3B9A0136629DC9125D61937A2360A4463120E373ABD5586DD6E71B137CA6CF003C37E22253C7CC5A424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v14 2/6] qsync: update confirmed lsn on initial promote request X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 13.09.2021 01:25, Cyrill Gorcunov пишет: > On Sun, Sep 12, 2021 at 05:44:04PM +0200, Vladislav Shpilevoy wrote: >> Thanks for the patch! >> >> On 10.09.2021 17:29, Cyrill Gorcunov wrote: >>> When promote request is handled we drop last confirmed >>> lsn to zero because its value make sense for sync queue >>> owner only. Still the case where we become queue owner >>> for the first time is special - we need to fetch the >>> obtained lsn from the request and remember it so we >>> will be able to filter any next malformed requests >>> with wrong lsn numbers (see queue filtering procedure >>> in next patch). >> I don't understand anything. Why isn't it needed always? And >> how exactly will it help to filter stuff? > This problem is revealed when run of ./test-run replication/gh-6034-qsync-limbo-ownership.test.lua > with filteration turned on. The confirmed_lsn make sence in bound > with limbo owner as far as I understand. And in test we have > two nodes "default" and "replica". Initially default gets up, filled > with some data into sync space and then we start up a replica node. > The replica get subscribed and then we call box.promote() on it, > since replica itself has not been writting anything its confirmed_lsn = 0, > which we send back to the "default" inside promote request body. And > it get rejected because "default" has non-zero confirmed_lsn. I've > been talking to Serge a lot about this problem and if I'm not missing > somthing obvious updating this filed on first promote arrival is > mostly correct way to handle the issue. I presume we should get > a meeting and talk again. > > Or maybe better via email. Serge could you please write the details here? It would be easier to discuss this verbally, I think. -- Serge Petrenko