From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 636B45ED22E; Tue, 5 Sep 2023 14:47:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 636B45ED22E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693914437; bh=i1whNAxBjMdLJvTyliX9zRMpYedEHmVOEh3wZ9V4c04=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=b82ilyk/BFc/euMSL79yxHp0H2904eFSTwu9i1E94hH23o+49vpA1vdKhxyQc1CKx E3qtvebRpv0L43K0zXzjbbCX+X0BY/bfpxpwmxymbhqTuPmQjgYmxFKzSv/i9eFHu1 7XQgb/o94cwZokuBTPT+uX00ZkSqGkxQwBiKZy+M= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 925285ECD6B for ; Tue, 5 Sep 2023 14:47:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 925285ECD6B Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qdUWZ-0003wE-Qt; Tue, 05 Sep 2023 14:47:16 +0300 Message-ID: <17d72b1b-0ac1-0f72-c72e-ff0f1f2d69f6@tarantool.org> Date: Tue, 5 Sep 2023 14:47:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org, skaplun@tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD96201AD55A1C8F7DB61D29A291ECBF3870B600DAE42344AB9182A05F5380850404C228DA9ACA6FE278DDBE3556BD24340F7CEE3E8F54DFB21B7D69CFB6B46440C1F7D964D66B1BE39 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7956F10FFCC7409BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063790C8302959DAAF098638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B71DD8900DF868B50D48269C7860D8C1117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCD78892F4CDBD81DDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0D75EB778CE7D8A0C68655334FD4449CB33AC447995A7AD1857739F23D657EF2BD5E8D9A59859A8B6F82A78844E5C6993089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5911A6D8F509B21E90A91BB1C693ECC66AAD2C33803DCF225F87CCE6106E1FC07E67D4AC08A07B9B0A6C7FFFE744CA7FBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF6D37CE98C5437BC65382E043D24CF66AECCA4100D1B63158EEF8778FABBC6C85245B1B6CBED8166AEA61C66FA002EE271A85EAE0BB68CB4A25CA060409355774A74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3VBHtC3oXrPxS50xYM1FUg== X-DA7885C5: 37EBEE1112764604711F3188FD55EFB7465A3AB1F8E6D1ED4828B15D53349920262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B0FD8F3E4096211C8F47E21883961925DDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] memprof: refactor symbol resolution X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Max thanks for the patch! LGTM with a two minor comments. It is not related to submitted patches, but anyway - there is a typo: --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua @@ -36,7 +36,7 @@ local function default_payload()    -- Preallocate table to avoid table array part reallocations.    local _ = table_new(20, 0) -  -- Want too see 20 objects here. +  -- Want to see 20 objects here.    for i = 1, 20 do      -- Try to avoid crossing with "test" module objects.      _[i] = "memprof-str-"..i On 8/28/23 18:23, Maxim Kokryashkin wrote: > This patch refactors symbol resolution in memprof, so > now they are resolved during the process of parsing. > This makes the generation mechanism excessive since > symtab updates are no longer affecting the previous events. > > Follows up tarantool/tarantool#8700 > --- > .../misclib-memprof-lapi.test.lua | 73 +++++-------------- > tools/memprof/humanize.lua | 16 ++-- > tools/memprof/parse.lua | 2 +- > tools/memprof/process.lua | 8 +- > 4 files changed, 31 insertions(+), 68 deletions(-) > > diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua > index 3cb5c8be..0eee4e21 100644 > --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua > +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua > @@ -78,7 +78,7 @@ local function generate_parsed_output(payload) > -- We don't need it any more. > os.remove(TMP_BINFILE) > > - return symbols, events > + return events > end > > local function form_source_line(line, source) > @@ -86,44 +86,13 @@ local function form_source_line(line, source) > end > > local function form_trace_line(traceno, line, source) > - return ("TRACE [%d] %s:%d"):format(traceno, source or SRC_PATH, line) > + return ("TRACE [%d] started at %s:%d"):format(traceno, source or SRC_PATH, line) > end Nit: this change is not relevant. In the branch hunk is different: @@ -86,44 +86,17 @@ local function form_source_line(line, source)  end  local function form_trace_line(traceno, line, source) -  return ("TRACE [%d] %s:%d"):format(traceno, source or SRC_PATH, line) +  return ("TRACE [%d] started at %s:%d"):format( +    traceno, +    source or SRC_PATH, +    line +  )  end >