From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EE8AB9D9B5D; Wed, 7 Feb 2024 09:50:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EE8AB9D9B5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707288659; bh=h6iXsecrLLYwzbaWd6zTqllrDXhJUrKv/CVWefqR6UI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mwES2TmhS0OAny6bIWfkND2GOW73DO1Z8QYoEYDVvgcI2l0OaRd1rVWkZ5z0h+Cxp f1O0zSm3pp9NLOyWTkI8uqGvTPVv21iWtziVTByLV+7pbHqHLzv7eSQ1XvWr20zyZ5 GOxrvtAx3KvAKG9ltYJAzSiPzHp/9th9OHY46tkY= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [95.163.41.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D796F9D9B55 for ; Wed, 7 Feb 2024 09:50:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D796F9D9B55 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1rXblp-0000000FPRz-0cEH; Wed, 07 Feb 2024 09:50:57 +0300 Message-ID: <178be49e-2359-44dd-ad42-e07971b71cae@tarantool.org> Date: Wed, 7 Feb 2024 09:50:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <620839b2-26a8-446d-83d8-e053c4cc61e6@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD94C460F083DF69F5190553CFE4D3947DFAEC6AB1FF362D218182A05F5380850400BE8ED1008FD46DB411046492FDDF806B0EABDCC52EF557C6D471AED9581EF33BD00B114EC3005A8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78E8764B5BC580342EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376EC5B14D896A2D978638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8ED7D6596ECC801A7E8F8E8FBD7FF5C63663314DBB525525DCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C2A336C65186350919735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C342F15A690964974ABA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFE478A468B35FE7671DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3517C622C16A6DF10089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5F4C13FE9A3A18AF35002B1117B3ED6968A5C39D664828208C638DF663A625AFA823CB91A9FED034534781492E4B8EEADBD39A56654533F91BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34951738D4D62E58A4A15E62BB6FE2D6500F7BDDBF3D8E73634BFBBFA2912A80B373B8A0D205140BEA1D7E09C32AA3244CAB249A78CD519C6B7215182CA7F28860EA9330E679E8DC2BEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnNBBsTnX8yL0A== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458B8EF72D5291E6B6AD4570605F44DF537A53DCCE05186CC4576362D9D423F04EE645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 06/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey thanks for fixes! LGTM as I said before. On 2/6/24 15:01, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comment. > > On 01.02.24, Sergey Bronnikov wrote: >> Hi, Sergey >> >> thanks for the patch! LGTM with minor comment below >> >> On 1/29/24 13:45, Sergey Kaplun wrote: >>> This patch removes unused `dofile()`. Also, it uses the basename of the >>> ctest library to be loaded via ffi. It adds groups with names of >>> subtests and enables the test in . Complex type is undefined on >>> Windows, so the correponding tests are not enabled for this platform. >>> Fastcalls are enabled only for the x86 architecture. Stdcalls are >>> enabled only for Windows on x86. Tests with calls with 10 arguments with >>> sizes less than 8 bits are dummy for M1. This suite lacks a mechanism to >> too much "with" for my taste :) feel free to ignore > Replaced the first "with" with:) containing. See the new commit message > below: > > | test: enable in LuaJIT-tests > | > | This patch removes unused `dofile()`. Also, it uses the basename of the > | ctest library to be loaded via ffi. It adds groups with names of > | subtests and enables the test in . Complex type is undefined on > | Windows, so the correponding tests are not enabled for this platform. > | Fastcalls are enabled only for the x86 architecture. Stdcalls are > | enabled only for Windows on x86. Tests containing calls with 10 > | arguments with sizes less than 8 bits are dummy for M1. This suite lacks > | a mechanism to skip subtests satisfying complicated conditions, so it is > | done manually by the corresponding `if` check. > | > | Part of tarantool/tarantool#9398 > >> Thanks for reformatting testcases, much more readable now. > It's a pleasure :). > >