From: Sergey Kaplun <skaplun@tarantool.org>
To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: Sergey Bronnikov <sergeyb@tarantool.org>,tarantool-patches@dev.tarantool.org
Date: Tuesday, June 30, 2026 1:09 PM +03:00
Hi, Evgeniy!
Thanks for the patch!
LGTM, with a few nits regarding the commit message.
On 29.06.26, Evgeniy Temirgaleev wrote:
> From: Mike Pall <mike>
>
> Thanks to Temir Galeev. #1470
Please strip the issue number here. See the rationale in the response to
the previous patch.
>
> (cherry picked from commit 295d45fb26de56498782c94594f31b97aef744ef)
>
> This patch prevents os.time() to return nil, when machine time is -1
Typo: s/to return nil/from returning nil/
> and some error occurs before os.time() call. In fact, this is
Typo: s/os.time() call/the os.time() call/
> a theoretical case, so no tests were added.
>
> Temir Galeev:
> * added the description for the patch
>
> Part of tarantool/tarantool#12480
> ---
<snipped>
--
Best regards,
Sergey Kaplun