From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2940828A3A for ; Sun, 3 Mar 2019 15:49:54 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sSffwg28KwII for ; Sun, 3 Mar 2019 15:49:54 -0500 (EST) Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C91D128A38 for ; Sun, 3 Mar 2019 15:49:53 -0500 (EST) From: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= Subject: [tarantool-patches] Re: [PATCH] Do not enable commit if read_only = true Date: Sun, 03 Mar 2019 23:49:46 +0300 Message-ID: <1779552.GDyJA9gWEY@home.lan> In-Reply-To: <20190228102530.GB18858@chai> References: <20190227090237.lu32o77lkyllgvui@esperanza> <20190228102530.GB18858@chai> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1967369.6tkajVDack"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Konstantin Osipov --nextPart1967369.6tkajVDack Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Thursday, February 28, 2019 1:25:30 PM MSK Konstantin Osipov wrote: > * Vladimir Davydov [19/02/27 12:26]: > > On Wed, Feb 27, 2019 at 10:36:00AM +0300, Georgy Kirichenko wrote: > > > Disable commit if server is in read only mode. > > > > The commit message is very poor. Please elaborate why this is important. > > Having thought about it we should go over all in-flight > transactions in vinyl and abort them. > > We already use this approach on DDL. > We could make it more general. I did a little investigation and found that current implementation does not allow us do reach expected behavior using vinyl aborts because of * transaction placed in the write set only after uniqueness check - this leads to a race if read only was set during this check. * it is valid only for vy_update and vy_upsert invocations. * ddl could stuck at schema_latch and continues after read_only was set. --nextPart1967369.6tkajVDack Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEFB+nbqWGnp59Rk9ZFSyY70x8X3sFAlx8PeoACgkQFSyY70x8 X3tHswf/cTrjUhqrwwqycnVYb1kgf1nUtmCaJeYSj+QseTlsKKgT6YJZ/fRklIZC m9/k+o1ykKyqk6c8hXztIgGwSZU3pyeipGfouFg07xHGZlkiSLXxVwFPdWnSo5/O lOdWPq/nSNFHWdCHWwMkrDJWvQCMmercIB3PD5HjHfvOakdziksDhUz4XRD8DXGf pMMLlhwd6aOUlZjytVceAIiqb99j9OA4O7X5nEkDEqvT24xXzLln+Eu8P9deVXYU ae0/fgYHDDOxFDDGDJvvu7cuDskz5Y9cUn7UUZUG0FvLbzWg25gbiJtCQpnjruhu U3uyzK6sXUM2JkGZfKWNd7ZkHkw5GA== =WBH4 -----END PGP SIGNATURE----- --nextPart1967369.6tkajVDack--