From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 22AC2201BD for ; Wed, 18 Apr 2018 03:10:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qwKSVFrTNYUO for ; Wed, 18 Apr 2018 03:10:48 -0400 (EDT) Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 71807200B5 for ; Wed, 18 Apr 2018 03:10:47 -0400 (EDT) From: Georgy Kirichenko Subject: [tarantool-patches] Re: [wal 1/1] wal: Update request header after sequence update Date: Wed, 18 Apr 2018 10:10:39 +0300 Message-ID: <1774392.XyMLadrm1s@home.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6326314.6Etq3FMT3x"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Ilya Markov Cc: tarantool-patches@freelists.org --nextPart6326314.6Etq3FMT3x Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Seems good for me Thanks for investigation On Tuesday, April 17, 2018 10:39:16 AM MSK Ilya Markov wrote: > When tuple in insert/replace request has NULL value > in the field incremented by sequence, > request body is changed, NULL is replaced by value taken from > sequence. > But request header is not updated. > So Redo log, which takes body from header if header exists, > writes the old version of request to wal. > > Fixed this with updating header value after handling the sequence. > > Closes #3247 > --- > branch gh-3247-wrong-sequence-primary-index --nextPart6326314.6Etq3FMT3x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEBJFDbU76LsBbgHBsvKOmCX79zb4FAlrW728ACgkQvKOmCX79 zb7KfAf/ar5I3Vw4hEDyt0K7wT5mJ7U4UidjUeQNYPH+CiZXUyMk7QJnlsF6OvDy Fat26YUcibwfZBP6sl1PUNstTcVnJGZQSHsmalPbdlh5+fX9RyWy25bIZsXH3UJG hnHSSA3jFrKLRHtcNfVEegzlWD8hg64ir9+Kd6CggbU/QANldFatwLwrbRWxSDMd O44z83icwPQ6TISzcx1b0dhW8ll9wYMdAITsT/ZgYiL8wGf9xJpRPesqUu9yhTes l445egBpPqK/YMq94j/L4uQ//5ks6uhn/yGiQF1xPnwHSKTSSidfIbQAwwrZP2am hc4fca0esQb5Fe+hQH52scei1YT5vg== =YH+Y -----END PGP SIGNATURE----- --nextPart6326314.6Etq3FMT3x--