From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BBB256EC41; Mon, 16 Aug 2021 18:57:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BBB256EC41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1629129453; bh=wPCsKq9G2NhD/P7GKOpKc5smWgP4LaGob5IGjLgVxjc=; h=To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=HRa2JL8qbCNH9dg+NyheZK6emFo26XhrpFXUvp48ZzXdUbTPfJ7UmX4drHQARYaCe Q/DfAFljSYJRUvnHD42KO6ZTzlzcTnSq7qK2F7rMbsrIdU2sRcTgxbatkGoCZIkFZz fSTHugGSNiUfzDDSMXdONAUAHtTyVqruu4T4d47s= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8E53D6EC43 for ; Mon, 16 Aug 2021 18:57:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8E53D6EC43 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mFeyy-0003Ah-KK; Mon, 16 Aug 2021 18:57:01 +0300 To: korablev@tarantool.org Cc: tarantool-patches@dev.tarantool.org Date: Mon, 16 Aug 2021 18:57:00 +0300 Message-Id: <175c9ed1210c35b9e51d89bf9abcdd2c0f941638.1629129129.git.imeevma@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9736CF3E71F18CE0C3E1D5927724F4AAA182A05F5380850406BF412ED8BAC63726FBEA13CC80163B60865BFAE07AF2D3A4111E3FEA9D083C1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BCC85671EC7A750CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637ED4AC1F45ACA54B08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8090F106C1496E15856F89A31DFC51B87117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50566263B10DCBA0F9A8B2796EF8D3FC7A2 X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C5B73F950BC6E7FFBCE1E5B26A8CC59D6DF9B6100D2900B039C2B6934AE262D3EE7EAB7254005DCED7532B743992DF240BDC6A1CF3F042BAD6DF99611D93F60EFE37876E7723AB534DC48ACC2A39D04F89CDFB48F4795C241BDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343F22CE0A71FDB37E74DA10A5C446E2067D68FB869F22D795290E929947B531A13BC719F3CB46D70B1D7E09C32AA3244CC4ADA63730C157707DCC00E25A025A2055E75C8D0ED9F6EE729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojIrFL/N5KnVFJ1GGhtb7W0w== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DE10A08DCDDD3AA8B4927D7A5145A0C2683D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: [Tarantool-patches] [PATCH v1 1/4] decimal: introduce decimal_is_neg() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: imeevma@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This patch introduces function decimal_is_neg() which checks that decimal is less than zero. Needed for #4415 --- src/lib/core/decimal.c | 6 ++++++ src/lib/core/decimal.h | 4 ++++ test/unit/decimal.c | 7 ++++++- test/unit/decimal.result | 10 +++++++++- 4 files changed, 25 insertions(+), 2 deletions(-) diff --git a/src/lib/core/decimal.c b/src/lib/core/decimal.c index 6d2ccb96f..7543ef44d 100644 --- a/src/lib/core/decimal.c +++ b/src/lib/core/decimal.c @@ -115,6 +115,12 @@ decimal_is_int(decimal_t *dec) return decNumberIsInt(dec); } +bool +decimal_is_neg(const decimal_t *dec) +{ + return decNumberIsNegative(dec) && !decNumberIsZero(dec); +} + decimal_t * decimal_from_string(decimal_t *dec, const char *str) { diff --git a/src/lib/core/decimal.h b/src/lib/core/decimal.h index aeafd2c68..15a576648 100644 --- a/src/lib/core/decimal.h +++ b/src/lib/core/decimal.h @@ -81,6 +81,10 @@ decimal_zero(decimal_t *dec); bool decimal_is_int(decimal_t *dec); +/** @return true if the decimal is negative, false otherwise. */ +bool +decimal_is_neg(const decimal_t *dec); + /** * Initialize a decimal with a value from the string. * diff --git a/test/unit/decimal.c b/test/unit/decimal.c index aea646e15..328b1b668 100644 --- a/test/unit/decimal.c +++ b/test/unit/decimal.c @@ -336,7 +336,7 @@ test_mp_print(void) int main(void) { - plan(304); + plan(312); dectest(314, 271, uint64, uint64_t); dectest(65535, 23456, uint64, uint64_t); @@ -416,5 +416,10 @@ main(void) dectest_is(is_int, 1.0000, true); dectest_is(is_int, 1.0000001, false); + dectest_is(is_neg, 1, false); + dectest_is(is_neg, -1, true); + dectest_is(is_neg, 0, false); + dectest_is(is_neg, -0, false); + return check_plan(); } diff --git a/test/unit/decimal.result b/test/unit/decimal.result index b7da2d2ce..ceaaf718a 100644 --- a/test/unit/decimal.result +++ b/test/unit/decimal.result @@ -1,4 +1,4 @@ -1..304 +1..312 ok 1 - decimal(314) ok 2 - decimal(271) ok 3 - decimal(314) + decimal(271) @@ -747,3 +747,11 @@ ok 301 - decimal_from_string(1.0000) ok 302 - decimal_is_int(1.0000) - expected true ok 303 - decimal_from_string(1.0000001) ok 304 - decimal_is_int(1.0000001) - expected false +ok 305 - decimal_from_string(1) +ok 306 - decimal_is_neg(1) - expected false +ok 307 - decimal_from_string(-1) +ok 308 - decimal_is_neg(-1) - expected true +ok 309 - decimal_from_string(0) +ok 310 - decimal_is_neg(0) - expected false +ok 311 - decimal_from_string(-0) +ok 312 - decimal_is_neg(-0) - expected false -- 2.25.1