From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C19796EC5B; Mon, 31 Aug 2026 12:37:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C19796EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1788169032; bh=xGXfbt7E1sp2oQIb9NMdCaDAcKRxzPXmlvp4oV8yA50=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YvB3kl61OfJqMkrO7T6op7sHefTbkDoSn0rKEHeR6Oi3nCGwg/ZtYtjcbmTG1bxAB S/7pOcySjnuvm927VTAAe8XGcrelCK4GfccqgJ9ZhHfVk7x0k1xlOcCPiHFIyoPMDm Aep7AN8/i/jdBBsbOJSwNlnEtH/1w05gworR02T4= Received: from send195.i.mail.ru (send195.i.mail.ru [95.163.59.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5B7376EC5B for ; Mon, 31 Aug 2026 12:37:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5B7376EC5B Received: by exim-smtp-67896c5f6-7pdhh with esmtpa (envelope-from ) id 1x0yRy-00000000KDH-16po; Mon, 31 Aug 2026 12:37:10 +0300 Content-Type: multipart/alternative; boundary="------------TEkgA4xYL013VmZK0m7eqfQz" Message-ID: <17508cbb-3f6e-43e3-bb9b-0ff84811c947@tarantool.org> Date: Mon, 31 Aug 2026 12:37:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Evgeniy Temirgaleev References: <20260807230049.13128-1-e.temirgaleev@tarantool.org> <3ea168e6-8841-4e94-aba2-70903a4deb0d@tarantool.org> <1787913937.662681336@f185.i.mail.ru> Content-Language: en-US In-Reply-To: <1787913937.662681336@f185.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95A8E7DCF34EF22721DCA8F4B38DE2F5D7FE13F0B7A3B1686182A05F5380850401830BAEC373A36AE3DE06ABAFEAF670512453ADA86FBEC5A9540000F8A9E3106888ABC412A473640 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F68DA2F3749BB650EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566D850E07A5DCD3FA81F0F9EF0714A318A64B511979B73DCFB4D38EB429D214A7F389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07734D68A6916D8318941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B60417BEADF48D1460CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE73A6989AD488FD87D731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5D2E7ED55FE38EB5A5002B1117B3ED6967D373CBEB16F2FE39E040399BDE4761E823CB91A9FED034534781492E4B8EEADDFC043C56F70D752BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6592FA78E5F823B1A2CBA3AF34CD2303AFA05F822A1968FF2533C97180D4DF6F86731B033FEF4C60516B8341EE9D5BE9A0AEDA9141A4DCEC52214B3F0A30C96924766D1CA73FFD17BF56536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVYRi1g7C0l6kTcFK5GGI+GA= X-Mailru-Sender: 689FA8AB762F73937C9FA53A4753B3137937B341906A208B8FDB7FA9F463321824D946CFFFE73FD4EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ci: unused gcc removed from macOS setup X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------TEkgA4xYL013VmZK0m7eqfQz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Thanks! LGTM On 8/28/26 13:45, Evgeniy Temirgaleev wrote: > Hi, Sergey! Thanks for review! > Fixed your suggestion. The branch is force pushed. > > From: Sergey Bronnikov > To: Evgeniy Temirgaleev , Sergey > Kaplun > Cc:tarantool-patches@dev.tarantool.org > Date: Thursday, August 27, 2026 12:35 PM +03:00 > > Hi, Evgeniy, > > thanks for the patch! LGTM with minor comments. > > Sergey > > On 8/8/26 02:00, Evgeniy Temirgaleev wrote: >> From: Temir Galeev >> >> The brew gcc installation is useless, because cmake use >> the clang compiler which is already present in the system. >> >> Also, the clang is better than gcc for macOS. >> >> Branch:https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac >> >> --- >> .github/actions/setup-macos/action.yml | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/.github/actions/setup-macos/action.yml b/.github/actions/setup-macos/action.yml >> index 91632648..9e752a70 100644 >> --- a/.github/actions/setup-macos/action.yml >> +++ b/.github/actions/setup-macos/action.yml >> @@ -32,6 +32,9 @@ runs: >> # Try to install the packages either upgrade it to avoid >> # of fails if the package already exists with the previous >> # version. >> - brew install --force cmake gcc make ninja perl || >> - brew upgrade cmake gcc make ninja perl >> + # We skip gcc installation because the 'builtin' clang compiler > > We usually write comments in a depersonalized manner and names in > uppercase: > > > Skip GCC installation because the 'builtin' clang compiler > > is already present in the system. It is used by CMake > > by default even if GCC is installed. > >> + # is already present in the system. It is used by cmake >> + # by default even if gcc is installed. >> + brew install --force cmake make ninja perl || >> + brew upgrade cmake make ninja perl >> shell: bash > > diff --git a/.github/actions/setup-macos/action.yml > b/.github/actions/setup-macos/action.yml > index 9e752a70..28693c3f 100644 > --- a/.github/actions/setup-macos/action.yml > +++ b/.github/actions/setup-macos/action.yml > @@ -32,9 +32,9 @@ runs: >          # Try to install the packages either upgrade it to avoid >          # of fails if the package already exists with the previous >          # version. > -        # We skip gcc installation because the 'builtin' clang compiler > -        # is already present in the system. It is used by cmake > -        # by default even if gcc is installed. > +        # Skip GCC installation because the 'builtin' Clang compiler > +        # is already present in the system. It is used by CMake > +        # by default even if GCC is installed. >          brew install --force cmake make ninja perl || >            brew upgrade cmake make ninja perl >        shell: bash > -- > Best regards, > Evgeniy Temirgaleev --------------TEkgA4xYL013VmZK0m7eqfQz Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Thanks! LGTM

On 8/28/26 13:45, Evgeniy Temirgaleev wrote:
Hi, Sergey! Thanks for review!
Fixed your suggestion. The branch is force pushed.
From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>, Sergey Kaplun <skaplun@tarantool.org>
Cc:tarantool-patches@dev.tarantool.org
Date: Thursday, August 27, 2026 12:35 PM +03:00
 

Hi, Evgeniy,

thanks for the patch! LGTM with minor comments.

Sergey

On 8/8/26 02:00, Evgeniy Temirgaleev wrote:
From: Temir Galeev <temir.galeev@bk.ru>

The brew gcc installation is useless, because cmake use
the clang compiler which is already present in the system.

Also, the clang is better than gcc for macOS.

Branch: https://github.com/tarantool/luajit/tree/tmr_g/lj-noticket-ci-build-mac

---
 .github/actions/setup-macos/action.yml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/actions/setup-macos/action.yml b/.github/actions/setup-macos/action.yml
index 91632648..9e752a70 100644
--- a/.github/actions/setup-macos/action.yml
+++ b/.github/actions/setup-macos/action.yml
@@ -32,6 +32,9 @@ runs:
         # Try to install the packages either upgrade it to avoid
         # of fails if the package already exists with the previous
         # version.
-        brew install --force cmake gcc make ninja perl ||
-          brew upgrade cmake gcc make ninja perl
+        # We skip gcc installation because the 'builtin' clang compiler

We usually write comments in a depersonalized manner and names in uppercase:

> Skip GCC installation because the 'builtin' clang compiler
> is already present in the system. It is used by CMake
> by default even if GCC is installed.

+        # is already present in the system. It is used by cmake
+        # by default even if gcc is installed.
+        brew install --force cmake make ninja perl ||
+          brew upgrade cmake make ninja perl
       shell: bash
diff --git a/.github/actions/setup-macos/action.yml b/.github/actions/setup-macos/action.yml
index 9e752a70..28693c3f 100644
--- a/.github/actions/setup-macos/action.yml
+++ b/.github/actions/setup-macos/action.yml
@@ -32,9 +32,9 @@ runs:
         # Try to install the packages either upgrade it to avoid
         # of fails if the package already exists with the previous
         # version.
-        # We skip gcc installation because the 'builtin' clang compiler
-        # is already present in the system. It is used by cmake
-        # by default even if gcc is installed.
+        # Skip GCC installation because the 'builtin' Clang compiler
+        # is already present in the system. It is used by CMake
+        # by default even if GCC is installed.
         brew install --force cmake make ninja perl ||
           brew upgrade cmake make ninja perl
       shell: bash
--
Best regards,
Evgeniy Temirgaleev
--------------TEkgA4xYL013VmZK0m7eqfQz--