From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 26F2124C72 for ; Thu, 29 Aug 2019 04:11:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9_chiP0RcQbP for ; Thu, 29 Aug 2019 04:11:48 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7998424688 for ; Thu, 29 Aug 2019 04:11:47 -0400 (EDT) From: Georgy Kirichenko Subject: [tarantool-patches] Re: [PATCH] Iproto call won't leak if transaction isn't committed Date: Thu, 29 Aug 2019 11:11:40 +0300 Message-ID: <1722586.TxYKutlovi@localhost> In-Reply-To: <20190828143235.44805-1-maria.khaydich@tarantool.org> References: <20190828143235.44805-1-maria.khaydich@tarantool.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6479792.2ZylAxH0jC"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Maria Khaydich --nextPart6479792.2ZylAxH0jC Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" LGTM, thanks! On Wednesday, August 28, 2019 5:32:35 PM MSK Maria Khaydich wrote: > In case of throwing client error because of unfinished > transaction we did not destroy used port. It could possibly > cause huge memory leaks as could be seen with top or its > analogues when performing net.box test run in a loop. > > Closes #4388 > --- > Issue: > https://github.com/tarantool/tarantool/issues/4388 > Branch: > https://github.com/tarantool/tarantool/tree/eljashm/gh-4388-uncommitted-ipro > to-leaks-not > > src/box/call.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/box/call.c b/src/box/call.c > index ac2bf3004..169210767 100644 > --- a/src/box/call.c > +++ b/src/box/call.c > @@ -132,6 +132,7 @@ box_process_call(struct call_request *request, struct > port *port) > > if (txn != NULL) { > diag_set(ClientError, ER_FUNCTION_TX_ACTIVE); > + port_destroy(port); > txn_rollback(txn); > fiber_gc(); > return -1; --nextPart6479792.2ZylAxH0jC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEFZT35EtIMRTDS5hJnoTdFFzh6LUFAl1niLwACgkQnoTdFFzh 6LVtaAf7Bh89Rbk0J9TgFSY3ZgNZ7nMsmDpVfluqNy0PEsReqRYUBexbEJF0a8iG sjV9/UPWgkY3ep++E3YIwLV9YCdoRU35RbhJxfaRDpZ5Ib8Dz1pnSnx3UFYAVrIY KsEpffo5IUKTfW4R/DCvprzzQBapBLTSy2qUSFdar+AvCZ15w/yL8oBEERix8Gbv ywsjZE8gRByOk4eUrYvvZUo9rwFRROgb1NLLc7j4mRO432LBmVsQBi7lb2XWTXJz nsZwGUGyTxSlcvurxYgwQLtWz37V8gm8/5JsH4Te2JcxXxqXXHUgq1DYrIq254NH CD8xS41GVvFUIVJMX7gprlWKd5ZPyQ== =FxwT -----END PGP SIGNATURE----- --nextPart6479792.2ZylAxH0jC--