From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6B0A5C6E78F; Thu, 22 Aug 2024 16:39:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6B0A5C6E78F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724333967; bh=1AZlTwj74dQgYt0kSKfm2jueAKmdQ9mYN/MBcJxGSGs=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zHgUEqqbpLQLZ06lkxAm5xhVQX/XFdjCYyyYxoXF9pmKJ/tuWtaBgPRuRKyFvcV6L lwywzbSozw+Vom/2+JQVVUBTuBBa86p2U/0z5yFvzjyx3/fUyKOK2E8sB5eDlzneyy bWRXurlKqFasLm7GYQAZP8Xp//YPM7704DfY9bOw= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 61494C6E78E for ; Thu, 22 Aug 2024 16:39:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 61494C6E78E Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1sh829-0000000EuyS-0vyG; Thu, 22 Aug 2024 16:39:25 +0300 Content-Type: multipart/alternative; boundary="------------auHC1DtdrTtkZuH11B0xvrt8" Message-ID: <16c0e6cc-d4a7-4e70-a30a-4cc902fa8853@tarantool.org> Date: Thu, 22 Aug 2024 16:39:24 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9E8EC46B20539565FB1E5540CB33AF2FFD182A05F538085040519CDB69A2E079A803ED270C30F246C5B32F39A168EBFBCC8C8D5969F79C319EDEB700F1740BDFE9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2EC3597058CFA6DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376D321F80F15DC2F18638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D815740EE2A550ABB470ACDB250B99813DE1FEDA8AF3DB64A3CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637F609FDC7BF3E55A5D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7D36F53DD076E3CB7EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C31205B1F03D11AAAB35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5489DABDC9BCE2DF25002B1117B3ED696A4CD1E08CA33E32B219207EC0A953D2C823CB91A9FED034534781492E4B8EEAD09F854029C6BD0DABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFDD7AAE2AAE5CF71837EC0D1B6452BD4455EA931ACE6EE5780DB5D5F7186493C44A7F0923522A066E2FB0CAD32ADFBF8406C0E86322ED7E3B62F7745E51A30218CA99E09AC3B86C635F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1XpLra984n9khA== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61407D1709705E8C1C84DBF0C6BC9FE70555B0726B7FD3D446A30152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 26/45] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------auHC1DtdrTtkZuH11B0xvrt8 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sergey, thanks for the patch! LGTM with a minor comment below. On 21.08.2024 11:58, Sergey Kaplun wrote: > This patch moves the aforementioned test from the to the > directory, includes it in , and names the subtests. > > Part of tarantool/tarantool#9398 > --- > .../{misc/phi_conv.lua => trace/phi/conv.lua} | 33 ++++++++++--------- > test/LuaJIT-tests/trace/phi/index | 1 + > 2 files changed, 19 insertions(+), 15 deletions(-) > rename test/LuaJIT-tests/{misc/phi_conv.lua => trace/phi/conv.lua} (69%) > > diff --git a/test/LuaJIT-tests/misc/phi_conv.lua b/test/LuaJIT-tests/trace/phi/conv.lua > similarity index 69% > rename from test/LuaJIT-tests/misc/phi_conv.lua > rename to test/LuaJIT-tests/trace/phi/conv.lua > index 8d7bea5f..267423c2 100644 > --- a/test/LuaJIT-tests/misc/phi_conv.lua > +++ b/test/LuaJIT-tests/trace/phi/conv.lua > @@ -1,18 +1,5 @@ > - > local bit = require("bit") > > -local Rm = {} > -for i=0,16 do Rm[i] = 0 end > - > -for k=1,10 do > - local seed = 1 > - for i=16,0,-1 do > - seed = bit.band(seed*9069, 0x7fffffff) > - Rm[i] = seed > - end > - assert(seed == 1952688301) > -end > - > local retindex = 0 > local retdata = { 3, 1, 1, 1, 0, 3, 1, 0, 0, 2, 0, 2, 0, 0, 3, 1, 1, 1, 1 } > > @@ -47,7 +34,23 @@ local function test() > end > end > > -if jit and jit.status and jit.status() then jit.opt.start("hotloop=1") end > +do --- PHI for CONV num.int before ASTORE. > + local Rm = {} > + for i=0,16 do Rm[i] = 0 end please add whitespaces > > -test() > + for k=1,10 do please add whitespaces > + local seed = 1 > + for i=16,0,-1 do please add whitespaces > + seed = bit.band(seed*9069, 0x7fffffff) > + Rm[i] = seed > + end > + assert(seed == 1952688301) > + end > +end > + > +do --- PHI for CONV num.int of lookup. > + jit.opt.start("hotloop=1") > + test() > + jit.opt.start("hotloop=56") > +end > > diff --git a/test/LuaJIT-tests/trace/phi/index b/test/LuaJIT-tests/trace/phi/index > index 74a07333..a72d37a0 100644 > --- a/test/LuaJIT-tests/trace/phi/index > +++ b/test/LuaJIT-tests/trace/phi/index > @@ -1,3 +1,4 @@ > copyspill.lua > +conv.lua > ref.lua > rotate.lua --------------auHC1DtdrTtkZuH11B0xvrt8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Sergey,

thanks for the patch! LGTM with a minor comment below.

On 21.08.2024 11:58, Sergey Kaplun wrote:
This patch moves the aforementioned test from the <misc> to the
<trace/phi/> directory, includes it in <index>, and names the subtests.

Part of tarantool/tarantool#9398
---
 .../{misc/phi_conv.lua => trace/phi/conv.lua} | 33 ++++++++++---------
 test/LuaJIT-tests/trace/phi/index             |  1 +
 2 files changed, 19 insertions(+), 15 deletions(-)
 rename test/LuaJIT-tests/{misc/phi_conv.lua => trace/phi/conv.lua} (69%)

diff --git a/test/LuaJIT-tests/misc/phi_conv.lua b/test/LuaJIT-tests/trace/phi/conv.lua
similarity index 69%
rename from test/LuaJIT-tests/misc/phi_conv.lua
rename to test/LuaJIT-tests/trace/phi/conv.lua
index 8d7bea5f..267423c2 100644
--- a/test/LuaJIT-tests/misc/phi_conv.lua
+++ b/test/LuaJIT-tests/trace/phi/conv.lua
@@ -1,18 +1,5 @@
-
 local bit = require("bit")
 
-local Rm = {}
-for i=0,16 do Rm[i] = 0 end
-
-for k=1,10 do
-  local seed = 1
-  for i=16,0,-1 do
-    seed = bit.band(seed*9069, 0x7fffffff)
-    Rm[i] = seed
-  end
-  assert(seed == 1952688301)
-end
-
 local retindex = 0
 local retdata = { 3, 1, 1, 1, 0, 3, 1, 0, 0, 2, 0, 2, 0, 0, 3, 1, 1, 1, 1 }
 
@@ -47,7 +34,23 @@ local function test()
   end
 end
 
-if jit and jit.status and jit.status() then jit.opt.start("hotloop=1") end
+do --- PHI for CONV num.int before ASTORE.
+  local Rm = {}
+  for i=0,16 do Rm[i] = 0 end
please add whitespaces 
 
-test()
+  for k=1,10 do
please add whitespaces
+    local seed = 1
+    for i=16,0,-1 do
please add whitespaces 
+      seed = bit.band(seed*9069, 0x7fffffff)
+      Rm[i] = seed
+    end
+    assert(seed == 1952688301)
+  end
+end
+
+do --- PHI for CONV num.int of lookup.
+  jit.opt.start("hotloop=1")
+  test()
+  jit.opt.start("hotloop=56")
+end
 
diff --git a/test/LuaJIT-tests/trace/phi/index b/test/LuaJIT-tests/trace/phi/index
index 74a07333..a72d37a0 100644
--- a/test/LuaJIT-tests/trace/phi/index
+++ b/test/LuaJIT-tests/trace/phi/index
@@ -1,3 +1,4 @@
 copyspill.lua
+conv.lua
 ref.lua
 rotate.lua
--------------auHC1DtdrTtkZuH11B0xvrt8--