From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2288B6EC5D; Tue, 6 Apr 2021 18:38:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2288B6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617723531; bh=Ie/PpRaiY7uZaZZQjQaUZQLdk1A412pgCdbJHZi0Ajg=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=iXQTn8PEqaLwjzkgcXr/eg5PXdKd85IEdTt6cxJnaBldWCcWd7DkYGcCawyLS4q3O 9M6gTg60b+Itl9KvU43illU6SP/OMpAgXdAB/vtNPQEhkZtEXcRABvS/eNGL79Eegu 5KSuHBcCqfAc2zdK3ZPsd/q8xjqfG7Fw56IwX4EU= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B31326EC5D for ; Tue, 6 Apr 2021 18:38:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B31326EC5D Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1lTnmx-0007DF-SS; Tue, 06 Apr 2021 18:38:48 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) In-Reply-To: <0f14e772231484f8ed786e499ac62be28dd2a484.1617641697.git.imun@tarantool.org> Date: Tue, 6 Apr 2021 18:38:46 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <16960D40-402C-410A-9CD1-14436A1838BE@tarantool.org> References: <0f14e772231484f8ed786e499ac62be28dd2a484.1617641697.git.imun@tarantool.org> To: Igor Munkin X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD912A3E3D5D4B49FC12DF659087DAACB92BFBA00DE2463A66B00894C459B0CD1B9414CE6111189B1C19544128E6C468DFA45E46AFC173FA292BB4A5D54B34CC71E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74C265300876DF183C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE71AB87D0AB0DD9D358F08D7030A58E5AD6BA297DBC24807EAA9D420A4CFB5DD3E57A7D300C180DC32F378314B93DC18711BA79017B6BCBBE08941B15DA834481FA18204E546F3947C1D471462564A2E19F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F790063783E00425F71A4181389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637F8DB709AF5FDCF73D81D268191BDAD3DBD4B6F7A4D31EC0BEA7A3FFF5B025636D81D268191BDAD3D78DA827A17800CE73082168B8AC718E6EC76A7562686271EEC990983EF5C03292E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3483320834B361D1F089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46DBD4A08EB2A9CFE09355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A557A7D300C180DC32F378314B93DC187133853FD6C87F722AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34BD150993ED26DDF47E00756F3414CE322695A19D9859636BE2561292CC80B8938402F53E2B1E12D01D7E09C32AA3244CA566279AA2A1C1A36933F98F85B64C1BFE8DA44ABE2443F7FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAX27rRizpLmFo4kI6voQbA== X-Mailru-Sender: 455D65AE3A139168626D8C76E86D3AC0414CE6111189B1C19544128E6C468DFADDAC019A3742A8B676D79013C85012CDC77752E0C033A69E4BBE7EBD99111A499D0AB74157175C036C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: remove excess dependency for tests target X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch, it is LGTM. Sergos > On 5 Apr 2021, at 20:11, Igor Munkin wrote: >=20 > TEST_DEPS list was introduced to prevent target from > being run in case no dependencies are changed. As a result of review = it > was decided to make all *-tests targets be .PHONY rules, hence = TEST_DEPS > variable is excess and can be dropped. >=20 > Follows up tarantool/tarantool#4862 >=20 > Signed-off-by: Igor Munkin > --- > test/tarantool-tests/CMakeLists.txt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/test/tarantool-tests/CMakeLists.txt = b/test/tarantool-tests/CMakeLists.txt > index 9bb26f32..3e36ff86 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -69,7 +69,6 @@ set(LUA_PATH > ) > set(LUA_TEST_SUFFIX .test.lua) > set(LUA_TEST_FLAGS --failures --shuffle) > -file(GLOB TEST_DEPS ${CMAKE_CURRENT_SOURCE_DIR}/*${LUA_TEST_SUFFIX}) >=20 > if(CMAKE_VERBOSE_MAKEFILE) > list(APPEND LUA_TEST_FLAGS --verbose) > @@ -78,7 +77,7 @@ endif() > # LUA_CPATH and LD_LIBRARY_PATH variables and also TESTLIBS list > # with dependecies are set in scope of BuildTestLib macro. > add_custom_target(tarantool-tests > - DEPENDS ${LUAJIT_TEST_BINARY} ${TESTLIBS} ${TEST_DEPS} > + DEPENDS ${LUAJIT_TEST_BINARY} ${TESTLIBS} > ) > add_custom_command(TARGET tarantool-tests > COMMENT "Running Tarantool tests" > --=20 > 2.25.0 >=20