From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3341A46970F
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 Nov 2019 02:07:36 +0300 (MSK)
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
References: <cover.1573121685.git.imeevma@gmail.com>
 <12ed4be2e7e433fdca58a43fc3b937eb9a54f52f.1573121685.git.imeevma@gmail.com>
 <9fe3bd05-17de-e878-4395-4d15cf2f0b38@tarantool.org>
 <20191107141209.GA10466@tarantool.org>
 <93979a0b-1708-1125-1142-74f22734b088@tarantool.org>
 <20191115140609.GA15961@tarantool.org>
 <3d76e64a-cd03-1bf1-5830-0d0b142a5e27@tarantool.org>
 <194ae7ab-61bc-797a-527e-81704ade2545@tarantool.org>
 <20191127103309.GA16066@tarantool.org>
 <3062f665-907c-7860-bbbd-430c89b6a66e@tarantool.org>
Message-ID: <1695bfaa-b250-ad14-848d-1a55fd13508c@tarantool.org>
Date: Thu, 28 Nov 2019 00:07:34 +0100
MIME-Version: 1.0
In-Reply-To: <3062f665-907c-7860-bbbd-430c89b6a66e@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 3/5] sql: introduce SET statement
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

No, stop. It is not LGTM.

1) Why on the branch I see a commit 

    "sql: refactor PRAGMA-related code"

But don't see it in this thread?

2) In a previous email I wrote this:

	- Parts of the message before '@Tarantoolbot document' and
	  after are in some ideas different, in some they are totally
	  the same. I propose you to remove the part before doc
	  request, and write the doc request more accurate. And check
	  again that all deleted PRAGMAs really don't work (in the last
	  patch), all new SETs really work, with exactly the same names
	  as in the commit message;

This is still actual. You wrote lots of text before docrequest,
and just a few lines after. The doc team will see the small part.
Once again, I propose you to drop the part before doc request,
and write everything after @Tarantoolbot document.