Hi, Sergey!
Thanks for the fixes!
LGTM
--
Best regards,
Maxim Kokryashkin
 
 
 
Sergey,


On 8/8/23 13:47, Sergey Kaplun wrote:


<snipped>
 
>>
>> diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
>> index 78abf2e1..13ea6c5b 100644
>> --- a/.github/workflows/coverage.yml
>> +++ b/.github/workflows/coverage.yml
>> @@ -50,8 +50,10 @@ jobs:
>>        - name: build
>>          run: cmake --build . --parallel
>>          working-directory: ${{ env.BUILDDIR }}
>> -      - name: test and generate code coverage report
>> -        run: cmake --build ${{ env.BUILDDIR }} --parallel --target coverage
>> +      - name: run regression tests
>> +        run: cmake --build ${{ env.BUILDDIR }} --parallel --target test
> I suppose it should be LuaJIT-test, since we don't want to run linters
> here. See also [1].
>
>
<snipped>

Fixed, thanks!


--- a/.github/workflows/coverage.yml
+++ b/.github/workflows/coverage.yml
@@ -51,7 +51,7 @@ jobs:
          run: cmake --build . --parallel
          working-directory: ${{ env.BUILDDIR }}
        - name: run regression tests
-        run: cmake --build ${{ env.BUILDDIR }} --parallel --target test
+        run: cmake --build ${{ env.BUILDDIR }} --parallel --target
LuaJIT-test
        - name: generate code coverage report
          run: cmake --build ${{ env.BUILDDIR }} --parallel --target
LuaJIT-coverage
        - name: send code coverage to coveralls.io