From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Bronnikov" <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 3/5][v3] cmake: introduce new targets
Date: Thu, 03 Aug 2023 22:38:09 +0300 [thread overview]
Message-ID: <1691091489.404344804@f148.i.mail.ru> (raw)
In-Reply-To: <dd443d836efaf90e32954d3061059bae796880c3.1690966149.git.sergeyb@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 3412 bytes --]
Hi, Sergey!
Please consider my comments below.
>
>>From: Sergey Bronnikov < sergeyb@tarantool.org >
>>
>>In Tarantool we use our own fork of checkpatch [1] with additional check
>>types. It's logical to use it in LuaJIT development. However, we don't
>>need to enable all checks [2] implemented in checkpatch, therefore a
>>number of checks are disabled.
>>
>>Patch introduces two new CMake targets: "LuaJIT-checkpatch", that checks
>>patches on top of the master branch using script checkpatch.pl, and
>Typo: s/using/using the/
>>target "check", that combines LuaJIT-luacheck and LuaJIT-checkpatch. By
>>default CMake looking for checkpatch.pl in a directory "checkpatch" in
>Typo: s/looking/looks/
>Typo: s/in a directory/in the directory/
>>LuaJIT repository root directory and in a directories specified in PATH.
>Typo: s/LuaJIT/the LuaJIT/
>Typo: s/a directories/directories/
>
>>
>>1. https://github.com/tarantool/checkpatch
>>2. https://github.com/tarantool/checkpatch/blob/master/doc/checkpatch.rst
>>---
>> test/CMakeLists.txt | 51 +++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 51 insertions(+)
>>
>>diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
>>index 47296a22..5ec0bed6 100644
>>--- a/test/CMakeLists.txt
>>+++ b/test/CMakeLists.txt
>>@@ -42,6 +42,56 @@ else()
>> )
>> endif()
>>
>>+find_program(CHECKPATCH checkpatch.pl
>>+ HINTS ${PROJECT_SOURCE_DIR}/checkpatch)
>>+add_custom_target(${PROJECT_NAME}-checkpatch)
>>+set(MASTER_BRANCH "tarantool/master")
>>+if(CHECKPATCH)
>>+ add_custom_command(TARGET ${PROJECT_NAME}-checkpatch
>>+ COMMENT "Running checkpatch"
>>+ COMMAND
>>+ ${CHECKPATCH}
>>+ # Description of supported checks in
>>+ # https://github.com/tarantool/checkpatch/blob/master/doc/checkpatch.rst
>>+ --codespell
>>+ --color=always
>>+ --git ${MASTER_BRANCH}..HEAD
>>+ --show-types
>>+ --ignore BAD_SIGN_OFF
>>+ --ignore BLOCK_COMMENT_STYLE
>>+ --ignore CODE_INDENT
>>+ --ignore COMMIT_LOG_LONG_LINE
>>+ # Requires at least two lines in commit message and this
>>+ # is annoying.
>>+ --ignore COMMIT_MESSAGE
>>+ --ignore CONSTANT_COMPARISON
>>+ --ignore FUNCTION_NAME_NO_NEWLINE
>>+ --ignore GIT_COMMIT_ID
>>+ --ignore INCLUDE_GUARD
>>+ --ignore LOGICAL_CONTINUATIONS
>>+ --ignore LONG_LINE
>>+ --ignore NO_CHANGELOG
>>+ --ignore NO_DOC
>>+ --ignore NO_TEST
>>+ --ignore PREFER_DEFINED_ATTRIBUTE_MACRO
>>+ --ignore SPACING
>>+ --ignore SUSPECT_CODE_INDENT
>>+ --ignore TABSTOP
>>+ --ignore TRAILING_STATEMENTS
>>+ --ignore UNCOMMENTED_DEFINITION
>>+ --ignore UNSAFE_FUNCTION
>>+ WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
>>+ )
>>+else()
>I suggest doing the same as with coverage — move that logic into a separate module,
>so the test/CMakeLists.txt remains readable and clean.
>>+ add_custom_command(TARGET ${PROJECT_NAME}-checkpatch
>>+ COMMENT "`checkpatch.pl' is not found, so ${PROJECT_NAME}-checkpatch target is dummy"
>>+ )
>>+endif()
>>+
>>+add_custom_target(check
>>+ DEPENDS ${PROJECT_NAME}-checkpatch ${PROJECT_NAME}-luacheck
>>+)
>>+
>> set(LUAJIT_TEST_COMMAND "${LUAJIT_TEST_BINARY} -e dofile[[${LUAJIT_TEST_INIT}]]")
>> separate_arguments(LUAJIT_TEST_COMMAND)
>>
>>@@ -75,5 +125,6 @@ if(LUAJIT_USE_TEST)
>> add_custom_target(test DEPENDS
>> ${PROJECT_NAME}-test
>> ${PROJECT_NAME}-luacheck
>>+ ${PROJECT_NAME}-checkpatch
>> )
>> endif()
>>--
>>2.34.1
>--
>Best regards,
>Maxim Kokryashkin
[-- Attachment #2: Type: text/html, Size: 5110 bytes --]
next prev parent reply other threads:[~2023-08-03 19:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 8:52 [Tarantool-patches] [PATCH 0/5][v3] Fix typos and enable checkpatch Sergey Bronnikov via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 1/5][v3] ci: fix a step name Sergey Bronnikov via Tarantool-patches
2023-08-03 19:27 ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 11:20 ` Sergey Kaplun via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 2/5][v3] codehealth: fix typos Sergey Bronnikov via Tarantool-patches
2023-08-03 19:29 ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 12:58 ` Sergey Kaplun via Tarantool-patches
2023-08-09 14:41 ` Sergey Bronnikov via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 3/5][v3] cmake: introduce new targets Sergey Bronnikov via Tarantool-patches
2023-08-03 19:38 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-08-04 10:56 ` Sergey Bronnikov via Tarantool-patches
2023-08-09 14:04 ` Sergey Kaplun via Tarantool-patches
2023-08-09 14:55 ` Sergey Bronnikov via Tarantool-patches
2023-08-09 15:45 ` Sergey Kaplun via Tarantool-patches
2023-08-15 8:57 ` Maxim Kokryashkin via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 4/5][v3] ci: enable checkpatch Sergey Bronnikov via Tarantool-patches
2023-08-03 19:38 ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 14:40 ` Sergey Kaplun via Tarantool-patches
2023-08-09 15:05 ` Sergey Bronnikov via Tarantool-patches
2023-08-14 9:22 ` Sergey Bronnikov via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 5/5][v3] test: fix codestyle Sergey Bronnikov via Tarantool-patches
2023-08-03 19:45 ` Maxim Kokryashkin via Tarantool-patches
2023-08-04 10:42 ` Sergey Bronnikov via Tarantool-patches
2023-08-09 14:07 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1691091489.404344804@f148.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH 3/5][v3] cmake: introduce new targets' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox