Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Kaplun" <skaplun@tarantool.org>
Cc: "Maxim Kokryashkin" <max.kokryashkin@gmail.com>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches]  [PATCH luajit v2 1/5] test: disable `lj-603-snap-restore` test
Date: Mon, 20 Mar 2023 17:09:38 +0300	[thread overview]
Message-ID: <1679321378.242854604@f164.i.mail.ru> (raw)
In-Reply-To: <ZBROEIuDGT1FIvZd@root>

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]


Hi!
>
>On 14.03.23, Maxim Kokryashkin wrote:
>> The test is extremely fragile and it is burdening
>> to fix it in scope of every major change.
>> ---
>> test/tarantool-tests/lj-603-err-snap-restore.test.lua | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/test/tarantool-tests/lj-603-err-snap-restore.test.lua b/test/tarantool-tests/lj-603-err-snap-restore.test.lua
>> index 6eb53dfd..2f2eec7d 100644
>> --- a/test/tarantool-tests/lj-603-err-snap-restore.test.lua
>> +++ b/test/tarantool-tests/lj-603-err-snap-restore.test.lua
>> @@ -2,7 +2,9 @@ local tap = require('tap')
>> -- Test to demonstrate the incorrect JIT behaviour when an error
>> -- is raised on restoration from the snapshot.
>> -- See also  https://github.com/LuaJIT/LuaJIT/issues/603 .
>> -local test = tap.test('lj-603-err-snap-restore')
>> +local test = tap.test('lj-603-err-snap-restore'):skipcond({
>> + ['Too fragile, temporarily disabled.'] = true
>> +})
>
>I've reverted your patch at the last commit (4d5e9afe) and everything
>working just fine. I suggest to drop these changes.
No, it does not work. Here is the branch[1] with that commit dropped,
and CI fails exactly because of that test. Moreover, I’ve tried to fix
that by declaring different amounts of local variables in the test
and it seems like it is necessary to declare different amounts for
GC64 and non-GC64 modes. 
 
[1]:  https://github.com/tarantool/luajit/tree/fckxorg/gh-7745-exp-excep
--
Best regards,
Maxim Kokryashkin
 

[-- Attachment #2: Type: text/html, Size: 2026 bytes --]

  reply	other threads:[~2023-03-20 14:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 12:01 [Tarantool-patches] [PATCH luajit v2 0/5] jit: add exception unwinding Maxim Kokryashkin via Tarantool-patches
2023-03-14 12:01 ` [Tarantool-patches] [PATCH luajit v2 1/5] test: disable `lj-603-snap-restore` test Maxim Kokryashkin via Tarantool-patches
2023-03-17 11:25   ` Sergey Kaplun via Tarantool-patches
2023-03-20 14:09     ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-03-14 12:01 ` [Tarantool-patches] [PATCH luajit v2 2/5] Handle on-trace OOM errors from helper functions Maxim Kokryashkin via Tarantool-patches
2023-03-14 12:01 ` [Tarantool-patches] [PATCH luajit v2 3/5] Disable unreliable assertion for external frame unwinding Maxim Kokryashkin via Tarantool-patches
2023-03-14 12:01 ` [Tarantool-patches] [PATCH luajit v2 4/5] OSX: " Maxim Kokryashkin via Tarantool-patches
2023-03-14 12:01 ` [Tarantool-patches] [PATCH luajit v2 5/5] Fix IR_RENAME snapshot number. Follow-up fix for a32aeadc Maxim Kokryashkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1679321378.242854604@f164.i.mail.ru \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches]  [PATCH luajit v2 1/5] test: disable `lj-603-snap-restore` test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox