Re: [Tarantool-patches] [PATCH v1 luajit 0/5] reworking C tests

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 3078 bytes --]


Hi!
Are you sure that issues tarantool/tarantool#781 is related?
 
--
Best regards,
Maxim Kokryashkin
 
  
>Среда, 15 марта 2023, 19:14 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:
> 
>The whole idea of the patch-set introduce module for LuaJIT C tests. It
>also, can be used for unit tests.
>* The first patch is the prerequisite for the patch-set. It fixes
>  LD_LIBRARY_PATH definition.
>* The 2nd and 3d patches provides an API and helper for writing the tests.
>* The last 2 patches rewrite existing tests that should be written in C in
>  the proper way.
>
>I'll be glad to hear some suggestions and ideas to improving the test
>module:).
>
>Branch:  https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-tarantool-c-tests
>PR:  https://github.com/tarantool/tarantool/pull/8444
>Related Issue:
>*  https://github.com/tarantool/tarantool/issues/7900
>*  https://github.com/tarantool/tarantool/issues/781
>
>Sergey Kaplun (5):
>  test: fix setting of {DY}LD_LIBRARY_PATH variables
>  test: introduce module for C tests
>  test: introduce utils.h helper for C tests
>  test: rewrite misclib-getmetrics-capi test in C
>  test: rewrite misclib-sysprof-capi test in C
>
> .gitignore | 1 +
> src/CMakeLists.txt | 2 +
> test/CMakeLists.txt | 2 +
> test/tarantool-c-tests/CMakeLists.txt | 67 ++++
> .../misclib-getmetrics-capi-script.lua} | 82 ++---
> .../misclib-getmetrics-capi.test.c | 341 ++++++++++++++++++
> .../misclib-sysprof-capi-script.lua | 35 ++
> .../misclib-sysprof-capi.test.c | 317 ++++++++++++++++
> test/tarantool-c-tests/test.c | 251 +++++++++++++
> test/tarantool-c-tests/test.h | 251 +++++++++++++
> test/tarantool-c-tests/utils.h | 63 ++++
> test/tarantool-tests/CMakeLists.txt | 11 +-
> .../misclib-getmetrics-capi/CMakeLists.txt | 1 -
> .../misclib-getmetrics-capi/testgetmetrics.c | 270 --------------
> .../misclib-sysprof-capi.test.lua | 54 ---
> .../misclib-sysprof-capi/CMakeLists.txt | 1 -
> .../misclib-sysprof-capi/testsysprof.c | 260 -------------
> 17 files changed, 1374 insertions(+), 635 deletions(-)
> create mode 100644 test/tarantool-c-tests/CMakeLists.txt
> rename test/{tarantool-tests/misclib-getmetrics-capi.test.lua => tarantool-c-tests/misclib-getmetrics-capi-script.lua} (68%)
> create mode 100644 test/tarantool-c-tests/misclib-getmetrics-capi.test.c
> create mode 100644 test/tarantool-c-tests/misclib-sysprof-capi-script.lua
> create mode 100644 test/tarantool-c-tests/misclib-sysprof-capi.test.c
> create mode 100644 test/tarantool-c-tests/test.c
> create mode 100644 test/tarantool-c-tests/test.h
> create mode 100644 test/tarantool-c-tests/utils.h
> delete mode 100644 test/tarantool-tests/misclib-getmetrics-capi/CMakeLists.txt
> delete mode 100644 test/tarantool-tests/misclib-getmetrics-capi/testgetmetrics.c
> delete mode 100644 test/tarantool-tests/misclib-sysprof-capi.test.lua
> delete mode 100644 test/tarantool-tests/misclib-sysprof-capi/CMakeLists.txt
> delete mode 100644 test/tarantool-tests/misclib-sysprof-capi/testsysprof.c
>
>--
>2.34.1
 

[-- Attachment #2: Type: text/html, Size: 4159 bytes --]