From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Igor Munkin" <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/5] ci: use LuaJIT-test target in testing workflows
Date: Tue, 28 Feb 2023 10:42:13 +0300 [thread overview]
Message-ID: <1677570133.69994758@f552.i.mail.ru> (raw)
In-Reply-To: <7a17c39be770a75ec507001e5c3ad097b01bae62.1677236706.git.imun@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]
Hi, Igor!
Thanks for the patch!
LGTM as trivial.
--
Best regards,
Maxim Kokryashkin
>Понедельник, 27 февраля 2023, 12:10 +03:00 от Igor Munkin <imun@tarantool.org>:
>
>There is no need to run linter checks (such as luacheck) in scope of the
>testing workflows, since there is a separate one for this. Hence, only
><LuaJIT-test> target should be used in these workflows.
>
>Signed-off-by: Igor Munkin < imun@tarantool.org >
>---
> .github/workflows/exotic-builds-testing.yml | 2 +-
> .github/workflows/testing.yml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
>index 67ab9cc3..62b83931 100644
>--- a/.github/workflows/exotic-builds-testing.yml
>+++ b/.github/workflows/exotic-builds-testing.yml
>@@ -74,5 +74,5 @@ jobs:
> run: cmake --build . --parallel
> working-directory: ${{ env.BUILDDIR }}
> - name: test
>- run: cmake --build . --parallel --target test
>+ run: cmake --build . --parallel --target LuaJIT-test
> working-directory: ${{ env.BUILDDIR }}
>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
>index b7a6cfe2..8300c443 100644
>--- a/.github/workflows/testing.yml
>+++ b/.github/workflows/testing.yml
>@@ -74,7 +74,7 @@ jobs:
> run: cmake --build . --parallel
> working-directory: ${{ env.BUILDDIR }}
> - name: test
>- run: cmake --build . --parallel --target test
>+ run: cmake --build . --parallel --target LuaJIT-test
> working-directory: ${{ env.BUILDDIR }}
>
>
>--
>2.30.2
[-- Attachment #2: Type: text/html, Size: 2552 bytes --]
next prev parent reply other threads:[~2023-02-28 7:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 9:07 [Tarantool-patches] [PATCH luajit 0/5] Tarantool tests enhancements Igor Munkin via Tarantool-patches
2023-02-27 9:07 ` [Tarantool-patches] [PATCH luajit 1/5] ci: use LuaJIT-test target in testing workflows Igor Munkin via Tarantool-patches
2023-02-27 9:41 ` Sergey Kaplun via Tarantool-patches
2023-02-28 7:42 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-02-27 9:07 ` [Tarantool-patches] [PATCH luajit 2/5] test: stop using utils.selfrun in tests Igor Munkin via Tarantool-patches
2023-02-27 10:08 ` Sergey Kaplun via Tarantool-patches
2023-02-27 18:04 ` Igor Munkin via Tarantool-patches
2023-02-28 7:46 ` Maxim Kokryashkin via Tarantool-patches
2023-02-27 9:07 ` [Tarantool-patches] [PATCH luajit 3/5] test: introduce test:skipall TAP helper Igor Munkin via Tarantool-patches
2023-02-27 9:51 ` Sergey Kaplun via Tarantool-patches
2023-02-27 18:04 ` Igor Munkin via Tarantool-patches
2023-02-28 7:51 ` Maxim Kokryashkin via Tarantool-patches
2023-02-28 16:26 ` Igor Munkin via Tarantool-patches
2023-02-27 9:07 ` [Tarantool-patches] [PATCH luajit 4/5] test: introduce test:skiprest " Igor Munkin via Tarantool-patches
2023-02-27 9:56 ` Sergey Kaplun via Tarantool-patches
2023-02-27 18:04 ` Igor Munkin via Tarantool-patches
2023-02-28 7:55 ` Maxim Kokryashkin via Tarantool-patches
2023-02-28 16:26 ` Igor Munkin via Tarantool-patches
2023-02-27 9:07 ` [Tarantool-patches] [PATCH luajit 5/5] test: make skipcond helper more convenient Igor Munkin via Tarantool-patches
2023-02-27 10:01 ` Sergey Kaplun via Tarantool-patches
2023-02-28 8:10 ` Maxim Kokryashkin via Tarantool-patches
2023-03-02 17:07 ` [Tarantool-patches] [PATCH luajit 0/5] Tarantool tests enhancements Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1677570133.69994758@f552.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/5] ci: use LuaJIT-test target in testing workflows' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox