Понедельник, 16 января 2023, 11:10 +03:00 от Igor Munkin <imun@tarantool.org>:
 

Sergey,

Thanks for your review!

On 13.01.23, Sergey Kaplun wrote:
> Hi, Igor!
>
> Thanks for the patch!
> LGTM, with a single question below.
>
> On 13.01.23, Maxim Kokryashkin wrote:
> >
> > Hi, Igor!
> > Thanks for the patch!
> > LGTM, except for a few nits below.

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>

> >  

<snipped>

> > >>"regular" ones need to be chosen for full LuaJIT testing. At the same
> > >>time there is no need to use "regular" runner for LuaJIT Static analysis
> > >>workflow, hence 'lightweight' label is added to <runs-on> list in
> > >>lint.yml workflow file.
> > >Shall we create the same patch for the gnumake workflow?
>
> I agree here. IMHO, we can use "lightweight" label for gnumake build as
> far as it tests only build, so doesn't require a lot of memory.

Replied to the Max thread.

>

<snipped>

>
> --
> Best regards,
> Sergey Kaplun

--
Best regards,
IM