From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Kaplun" <skaplun@tarantool.org>
Cc: "Maxim Kokryashkin" <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] GC64: enable sysprof support
Date: Sat, 26 Nov 2022 10:13:13 +0300 [thread overview]
Message-ID: <1669446793.97973431@f188.i.mail.ru> (raw)
In-Reply-To: <Y38gjWDy758pLfmo@root>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
Hi, Sergey!
Thanks for the review!
>
>>Hi, Maxim!
>>Thanks for the patch!
>>
>>LGTM, with a single nit regarding the commit message.
>>
>>On 11.11.22, Maxim Kokryashkin wrote:
>>> This patch reverts changes introduced via commit
>>> 71e7020637bb15024ceb7e93ce66b61870567339 ('GC64: disable
>>> sysprof support'), fixing the incorrect behavior in vm
>>
>>Typo: s/in vm/in the VM/
>Fixed. The branch is force pushed.
><snipped>
>--
>Best regards,
>Maxim Kokryashkin
>
[-- Attachment #2: Type: text/html, Size: 946 bytes --]
next prev parent reply other threads:[~2022-11-26 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 10:19 Maxim Kokryashkin via Tarantool-patches
2022-11-24 7:43 ` Sergey Kaplun via Tarantool-patches
2022-11-26 7:13 ` Maxim Kokryashkin via Tarantool-patches [this message]
2022-11-30 16:04 ` sergos via Tarantool-patches
2022-12-12 9:43 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1669446793.97973431@f188.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] GC64: enable sysprof support' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox