From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: "Sergey Kaplun" <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Add tonumber() specialization for failed conversions. Date: Mon, 19 Sep 2022 10:50:07 +0300 [thread overview] Message-ID: <1663573807.727706952@f769.i.mail.ru> (raw) In-Reply-To: <20220912080158.12220-1-skaplun@tarantool.org> [-- Attachment #1: Type: text/plain, Size: 775 bytes --] Hi, Sergey! Thanks for the patch! LGTM, except for a single nit below: > >When `tonumber()` is recorded (as a part of a trace) for cdata argument >can't be converted to number the `nil` value is recorded as the yielded >result. But without special check on trace for cdata type this nil will >be returned for another type of cdata that can be converted. The first sentence lacks commas and is completely unreadable. I suggest the following fix: | When `tonumber()` is recorded (as a part of a trace) for a cdata argument that can't be converted to number, the `nil` value is | recorded as the yielded result. > >This patch adds the corresponding check for recoding of failed cdata >conversions. Typo: s/recoding/recording <snipped> -- Best regards, Maxim Kokryashkin [-- Attachment #2: Type: text/html, Size: 1183 bytes --]
next prev parent reply other threads:[~2022-09-19 7:50 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-12 8:01 Sergey Kaplun via Tarantool-patches 2022-09-19 7:50 ` Maxim Kokryashkin via Tarantool-patches [this message] 2022-09-20 8:53 ` sergos via Tarantool-patches 2022-09-20 9:58 ` Maxim Kokryashkin via Tarantool-patches 2022-09-20 10:10 ` sergos via Tarantool-patches 2022-09-21 12:03 ` Sergey Kaplun via Tarantool-patches 2022-09-21 12:19 ` sergos via Tarantool-patches 2022-09-22 11:28 ` Sergey Kaplun via Tarantool-patches 2022-09-25 21:37 ` sergos via Tarantool-patches 2022-09-28 7:37 ` Sergey Kaplun via Tarantool-patches 2022-09-24 14:49 ` Sergey Kaplun via Tarantool-patches 2022-11-11 8:54 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1663573807.727706952@f769.i.mail.ru \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] FFI: Add tonumber() specialization for failed conversions.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox