From: Vitaliia Ioffe via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Vladimir Davydov" <vdavydov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 0/7] Rework SCALAR and NUMBER types in SQL
Date: Tue, 17 Aug 2021 14:30:36 +0300 [thread overview]
Message-ID: <1629199836.175629348@f157.i.mail.ru> (raw)
In-Reply-To: <20210813160819.7j7zyk23we5sfpm5@esperanza>
[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]
QA lgtm
--
Vitaliia Ioffe
>Пятница, 13 августа 2021, 19:08 +03:00 от Vladimir Davydov via Tarantool-patches <tarantool-patches@dev.tarantool.org>:
>
>On Fri, Aug 13, 2021 at 06:12:52AM +0300, imeevma@tarantool.org wrote:
>> This patch reworks SCALAR and NUMBER types. Afther these patches SCANAR and
>> NUMBER values will follow newly defined rules. However, only one SQL built-in
>> function is actually changed in this patch. All other functions that should be
>> changed will be reworked in issue #6105.
>>
>> https://github.com/tarantool/tarantool/issues/6221
>> https://github.com/tarantool/tarantool/tree/imeevma/gh-6221-introduce-mem-type-number
>>
>> Mergen Imeev (7):
>> sql: remove enum field_type from struct Mem
>> sql: re-introduce NUMBER and SCALAR meta-types
>> sql: disallow implicit cast from NUMBER and SCALAR
>> sql: disallow arithmetic for NUMBER and SCALAR
>> sql: disallow bitwise for NUMBER and SCALAR
>> sql: disallow concatination for SCALAR
>> sql: fix comparison with SCALAR value
>LGTM
[-- Attachment #2: Type: text/html, Size: 1843 bytes --]
next prev parent reply other threads:[~2021-08-17 11:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 3:12 Mergen Imeev via Tarantool-patches
2021-08-13 3:12 ` [Tarantool-patches] [PATCH v1 1/7] sql: remove enum field_type from struct Mem Mergen Imeev via Tarantool-patches
2021-08-13 3:12 ` [Tarantool-patches] [PATCH v1 2/7] sql: re-introduce NUMBER and SCALAR meta-types Mergen Imeev via Tarantool-patches
2021-08-13 3:12 ` [Tarantool-patches] [PATCH v1 3/7] sql: disallow implicit cast from NUMBER and SCALAR Mergen Imeev via Tarantool-patches
2021-08-13 3:13 ` [Tarantool-patches] [PATCH v1 4/7] sql: disallow arithmetic for " Mergen Imeev via Tarantool-patches
2021-08-13 3:13 ` [Tarantool-patches] [PATCH v1 5/7] sql: disallow bitwise " Mergen Imeev via Tarantool-patches
2021-08-13 3:13 ` [Tarantool-patches] [PATCH v1 6/7] sql: disallow concatination for SCALAR Mergen Imeev via Tarantool-patches
2021-08-13 3:13 ` [Tarantool-patches] [PATCH v1 7/7] sql: fix comparison with SCALAR value Mergen Imeev via Tarantool-patches
2021-08-13 16:08 ` [Tarantool-patches] [PATCH v1 0/7] Rework SCALAR and NUMBER types in SQL Vladimir Davydov via Tarantool-patches
2021-08-17 11:30 ` Vitaliia Ioffe via Tarantool-patches [this message]
2021-08-18 12:29 ` Kirill Yukhin via Tarantool-patches
-- strict thread matches above, loose matches on Subject: below --
2021-08-11 16:01 Mergen Imeev via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629199836.175629348@f157.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=v.ioffe@tarantool.org \
--cc=vdavydov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 0/7] Rework SCALAR and NUMBER types in SQL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox