From: Vitaliia Ioffe via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Serge Petrenko" <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] allow upgrading from version 1.6
Date: Sat, 14 Aug 2021 11:12:25 +0300 [thread overview]
Message-ID: <1628928745.847656364@f418.i.mail.ru> (raw)
In-Reply-To: <cover.1628810253.git.sergepetrenko@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]
Hi team,
QA LGTM
--
Vitaliia Ioffe
>Пятница, 13 августа 2021, 2:32 +03:00 от Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>:
>
>Changes in v2:
> - Review fixes as per reviews from Sergos, Vladimir
> - Fix triggers being run on xlogs resulting from
> box.schema.ugrade()
> - Introduce table.equals in a separate commit.
> Use it to define whether some schema changes were
> already applied.
>
>https://github.com/tarantool/tarantool/issues/5894
>https://github.com/tarantool/tarantool/tree/sp/gh-5894-1.6-upgrade
>
>Serge Petrenko (2):
> lua: introduce table.equals method
> box: allow upgrading from version 1.6
>
> src/box/lua/load_cfg.lua | 14 +
> src/box/lua/upgrade.lua | 276 +++++++++++-
> src/lua/table.lua | 26 ++
> test/app-tap/table.test.lua | 31 +-
> test/xlog/gh-5894-pre-1.7.7-upgrade.result | 400 ++++++++++++++++++
> test/xlog/gh-5894-pre-1.7.7-upgrade.test.lua | 77 ++++
> .../1.6.8/gh-5894-pre-1.7.7-upgrade/fill.lua | 1 +
> .../1.7.1/gh-5894-pre-1.7.7-upgrade/fill.lua | 1 +
> .../1.7.2/gh-5894-pre-1.7.7-upgrade/fill.lua | 1 +
> .../1.7.5/gh-5894-pre-1.7.7-upgrade/fill.lua | 1 +
> test/xlog/upgrade/fill.lua | 4 +
> 11 files changed, 829 insertions(+), 3 deletions(-)
> create mode 100644 test/xlog/gh-5894-pre-1.7.7-upgrade.result
> create mode 100644 test/xlog/gh-5894-pre-1.7.7-upgrade.test.lua
> create mode 120000 test/xlog/upgrade/1.6.8/gh-5894-pre-1.7.7-upgrade/fill.lua
> create mode 120000 test/xlog/upgrade/1.7.1/gh-5894-pre-1.7.7-upgrade/fill.lua
> create mode 120000 test/xlog/upgrade/1.7.2/gh-5894-pre-1.7.7-upgrade/fill.lua
> create mode 120000 test/xlog/upgrade/1.7.5/gh-5894-pre-1.7.7-upgrade/fill.lua
>
>--
>2.30.1 (Apple Git-130)
[-- Attachment #2: Type: text/html, Size: 2657 bytes --]
next prev parent reply other threads:[~2021-08-14 8:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 23:30 Serge Petrenko via Tarantool-patches
2021-08-12 23:30 ` [Tarantool-patches] [PATCH v2 1/2] lua: introduce table.equals method Serge Petrenko via Tarantool-patches
2021-08-13 5:30 ` Oleg Babin via Tarantool-patches
2021-08-13 10:22 ` Serge Petrenko via Tarantool-patches
2021-08-13 20:13 ` Oleg Babin via Tarantool-patches
2021-08-16 7:53 ` Serge Petrenko via Tarantool-patches
2021-08-16 13:03 ` Бабин Олег via Tarantool-patches
2021-08-16 15:36 ` Serge Petrenko via Tarantool-patches
2021-08-16 15:41 ` Бабин Олег via Tarantool-patches
2021-08-16 16:47 ` Serge Petrenko via Tarantool-patches
2021-08-13 11:41 ` Vladimir Davydov via Tarantool-patches
2021-08-12 23:30 ` [Tarantool-patches] [PATCH v2 2/2] box: allow upgrading from version 1.6 Serge Petrenko via Tarantool-patches
2021-08-13 11:40 ` Vladimir Davydov via Tarantool-patches
2021-08-16 13:18 ` Бабин Олег via Tarantool-patches
2021-08-16 16:32 ` Serge Petrenko via Tarantool-patches
2021-08-16 18:22 ` Бабин Олег via Tarantool-patches
2021-08-14 8:12 ` Vitaliia Ioffe via Tarantool-patches [this message]
2021-08-17 7:28 ` [Tarantool-patches] [PATCH v2 0/2] " Kirill Yukhin via Tarantool-patches
2021-08-17 8:05 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1628928745.847656364@f418.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=v.ioffe@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] allow upgrading from version 1.6' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox