Max,
Thanks for the patch! The changes are fine, so no comments regarding
them, but please consider the nit regarding the commit message.
On 20.07.21, Maxim Kokryashkin wrote:
> Backports 'supoort Tarantool' patch[1] from lua-Harness.
Please, describe the changes in details. E.g. it's worth to mention that
this patch introduces lua-Harness profile for Tarantool considering the
platform specifics. Furthermore, these changes skips all CLI-related
tests for Tarantool binary, so 241-standalone.t and 411-luajit.t can be
renamed back.
>
> [1]:
https://framagit.org/fperrad/lua-Harness/-/commit/d3ceee16>
> Part of tarantool/tarantool#5970
> Part of tarantool/tarantool#4473
> ---
> ...standalone.t.disabled => 241-standalone.t} | 5 ++
> test/lua-Harness-tests/320-stdin.t | 2 +-
> .../{411-luajit.t.disabled => 411-luajit.t} | 2 +-
> test/lua-Harness-tests/profile_tarantool.lua | 63 +++++++++++++++++++
> 4 files changed, 70 insertions(+), 2 deletions(-)
> rename test/lua-Harness-tests/{241-standalone.t.disabled => 241-standalone.t} (99%)
> rename test/lua-Harness-tests/{411-luajit.t.disabled => 411-luajit.t} (99%)
> create mode 100644 test/lua-Harness-tests/profile_tarantool.lua
>
<snipped>
> --
> 2.32.0
>
--
Best regards,
IM