From: "Evgeny Mekhanik" <mechanik20051988@tarantool.org>
To: "Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] FW: [PATCH v2 3/3] small: changed small allocator pool management
Date: Fri, 25 Dec 2020 10:52:34 +0300 [thread overview]
Message-ID: <1608882754.698179352@f122.i.mail.ru> (raw)
In-Reply-To: <27E47303-4307-4713-BB8A-2427FED09DDE@hxcore.ol>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
On 23.12.2020 14:14, mechanik20051988 wrote:
> 1. Fxed
> 2. As i understand you comment, you wrote that pools
> should be aligned on the 8-byte boundary.
> This is guaranteed by the granularity parameter in small_class if min_alloc
> have 8-byte boundary alignment. We calculate
> min_alloc = objsize_min = small_align(objsize_min, sizeof(intptr_t));
> and pass granularity sizeof(uintptr_t).
No, I meant the indentation alignment is broken. If a
function call consists of multiple lines, the non-first
lines should be aligned by '(' + 1. See examples in
the existing code.
Change alignment in code, see below:
+ small_class_create(&alloc->small_class, sizeof(intptr_t),
+ alloc->factor, objsize_min);
+ factor_pool_create(alloc);
lifo_init(&alloc->delayed);
lifo_init(&alloc->delayed_large);
[-- Attachment #2: Type: text/html, Size: 2051 bytes --]
next prev parent reply other threads:[~2020-12-25 7:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 13:14 [Tarantool-patches] [PATCH v2 0/3] change small allocator behavior mechanik20051988
2020-12-23 13:14 ` [Tarantool-patches] [PATCH] memtx: " mechanik20051988
2020-12-24 15:13 ` Vladislav Shpilevoy
[not found] ` <0076A088-8CBC-4238-9EEB-0C73EC516098@hxcore.ol>
2020-12-25 7:42 ` [Tarantool-patches] FW: " Evgeny Mekhanik
2020-12-28 12:10 ` Vladislav Shpilevoy
2020-12-23 13:14 ` [Tarantool-patches] [PATCH v2 1/3] small: implement new size class evaluation mechanik20051988
2020-12-24 15:13 ` Vladislav Shpilevoy
[not found] ` <A90D94B7-298A-4D1B-8134-6EE2ED45D615@hxcore.ol>
2020-12-25 7:48 ` [Tarantool-patches] FW: " Evgeny Mekhanik
2020-12-28 12:10 ` [Tarantool-patches] " Vladislav Shpilevoy
2020-12-23 13:14 ` [Tarantool-patches] [PATCH v2 2/3] test: add small allocator performance test mechanik20051988
2020-12-23 13:14 ` [Tarantool-patches] [PATCH v2 3/3] small: changed small allocator pool management mechanik20051988
2020-12-24 15:13 ` Vladislav Shpilevoy
[not found] ` <27E47303-4307-4713-BB8A-2427FED09DDE@hxcore.ol>
2020-12-25 7:52 ` Evgeny Mekhanik [this message]
2020-12-25 7:56 ` [Tarantool-patches] FW: " Evgeny Mekhanik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608882754.698179352@f122.i.mail.ru \
--to=mechanik20051988@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] FW: [PATCH v2 3/3] small: changed small allocator pool management' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox