Четверг, 21 мая 2020, 19:10 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
Hi, Oleg
Thanks for the patch! See my coments inline.
> # Release
>
> build_debian:
> - cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON ${CMAKE_EXTRA_PARAMS}
> + cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON -DENABLE_DIST=ON ${CMAKE_EXTRA_PARAMS}
Why do we need ENABLE_WERROR here?
> +# Integration testing
> +
> +test_connector_python_asynctnt: build_debian
> + make install
Let's create a separate target for tarantool installation and add it to
dependence. Same for targets below.
The same question as for vshard - why should we test tarantool against
unreleased versions of connectors?