LGTM

 
Четверг, 21 мая 2020, 22:43 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
 
Hi, Alexander

thanks for the patch, LGTM

On 21:35 Wed 20 May , Alexander V. Tikhonov wrote:
> Set full testing with deploy builds and tests for all branches.
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/all-tests-in-branches
>
> .gitlab-ci.yml | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 256b368c4..55b006ed4 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -8,11 +8,6 @@ variables:
>
> # Jobs templates
>
> -.release_only_template: &release_only_definition
> - only:
> - - master
> - - /^.*-full-ci$/
> -
> .deploy_only_template: &deploy_only_definition
> only:
> - master
> @@ -26,7 +21,8 @@ variables:
> - schedules
> - external_pull_requests
> - merge_requests
> - - /^.*-full-ci$/
> + - branches
> + - tags
>
> .perf_only_template: &perf_only_definition
> only:
> @@ -124,7 +120,6 @@ release_clang:
> - ${GITLAB_MAKE} test_debian_no_deps
>
> release_lto:
> - <<: *release_only_definition
> <<: *docker_test_clang8_definition
> variables:
> CMAKE_EXTRA_PARAMS: -DENABLE_LTO=ON
> @@ -132,7 +127,6 @@ release_lto:
> - ${GITLAB_MAKE} test_debian_no_deps
>
> release_lto_clang8:
> - <<: *release_only_definition
> <<: *docker_test_clang8_definition
> variables:
> CC: clang-8
> @@ -147,7 +141,6 @@ release_asan_clang8:
> - ${GITLAB_MAKE} test_asan_debian_no_deps
>
> osx_14_release:
> - <<: *release_only_definition
> stage: test
> tags:
> - osx_14
> @@ -162,7 +155,6 @@ osx_15_release:
> - ${GITLAB_MAKE} test_osx
>
> osx_15_release_lto:
> - <<: *release_only_definition
> stage: test
> tags:
> - osx_15
> @@ -466,7 +458,6 @@ static_build:
> - ${GITLAB_MAKE} test_static_build
>
> static_docker_build:
> - <<: *release_only_definition
> stage: test
> tags:
> - deploy_test
> --
> 2.17.1
>

--
sergeyb@
 
 
--
Oleg Piskunov