Tarantool development patches archive
 help / color / mirror / Atom feed
From: Timur Safin <tsafin@tarantool.org>
To: alexander.turenko@tarantool.org, avtikhon@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH] module api: fix asan failures in test
Date: Fri, 16 Oct 2020 19:57:28 +0300	[thread overview]
Message-ID: <158f8ce7d18ca54cc2ed343ecd3d19d686220f1d.1602867171.git.tsafin@tarantool.org> (raw)

Adding forgotten resource cleanup to the
`test_tuple_validate_formatted` test, to make ASAN
happy again.

Closes #5432
Relates to #5384
---

Branch is tsafin/gh-5432-module-api-asan-fix

 test/app-tap/module_api.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/app-tap/module_api.c b/test/app-tap/module_api.c
index 7ca0c9a15..ce7fa2353 100644
--- a/test/app-tap/module_api.c
+++ b/test/app-tap/module_api.c
@@ -2327,6 +2327,8 @@ test_tuple_validate_formatted(lua_State *L)
 		assert(format);
 
 		valid = box_tuple_validate(tuple, format) == 0;
+		box_tuple_format_unref(format);
+		box_key_def_delete(key_defs[0]);
 	}
 	lua_pushboolean(L, valid);
 
-- 
2.20.1

             reply	other threads:[~2020-10-16 16:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 16:57 Timur Safin [this message]
2020-10-16 17:17 ` Alexander V. Tikhonov
2020-10-17  5:17 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158f8ce7d18ca54cc2ed343ecd3d19d686220f1d.1602867171.git.tsafin@tarantool.org \
    --to=tsafin@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] module api: fix asan failures in test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox