LGTM
 
Вторник, 14 апреля 2020, 11:28 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
 
Thanks for the patch!

LGTM

On 17:03 Tue 07 Apr , Alexander V. Tikhonov wrote:
> Found that static build based on Dockerfile used external link
> and missed that it was removed, like it was in #4830. To avoid
> of the same issues the cache for building the Dockerfile was
> disabled with '--no-cache' option at docker build command.
>
> Follow up #4830
> ---
> .travis.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.mk b/.travis.mk
> index f709a18b6..54a4d5d91 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -143,7 +143,7 @@ test_static_build: deps_debian_static
> CMAKE_EXTRA_PARAMS=-DBUILD_STATIC=ON make -f .travis.mk test_debian_no_deps
>
> test_static_docker_build:
> - docker build --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
> + docker build --no-cache --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
>
> #######
> # OSX #
> --
> 2.17.1
>

--
sergeyb@
 
 
--
Oleg Piskunov