Hi Oleg, thanks for the review, as I see the only question why we may need this patch as a temporary solution. The purpose of this patch is to save the stability of the testing code on OSX version, while this is the only way to test it. It can be used in the standalone branch as it is, without pushing to mainline.

 
Понедельник, 13 апреля 2020, 13:50 +03:00 от Oleg Piskunov <o.piskunov@tarantool.org>:
 
Hi,
 
Sasha, thanks for the patch. See my comment below.
 
Четверг, 9 апреля 2020, 11:41 +03:00 от Alexander V. Tikhonov <avtikhon@tarantool.org>:
 
Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
due to decided to have only 2 last major releases, for now it is
10.14 and 10.15 OSX versions. Also changed the commit job for branches
from 10.14 to 10.15 OSX version.
As far as I remember we agreed to use new HW mac mini for testing 10.15 OSX version.
I don’t understand why you trying to use VMS for it.

Added to OSX 10.15 additional call to /etc/profile to setup the PATH,
otherwise it doesn't have the path to brew installed packages.
---
 .gitlab-ci.yml | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index cd710027f..5c9f353a7 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -139,19 +139,20 @@ release_asan_clang8:
   script:
     - ${GITLAB_MAKE} test_asan_debian_no_deps
 
-osx_13_release:
- <<: *release_only_definition
+osx_15_release:
   <<: *vbox_definition
   tags:
- - vms_osx_13
+ - vms_osx_15
   variables:
- VMS_NAME: 'osx_13'
+ EXTRA_ENV: '. /etc/profile ;'
+ VMS_NAME: 'osx_15'
     VMS_USER: 'tarantool'
- VMS_PORT: '2212'
+ VMS_PORT: '2242'
   script:
     - ${GITLAB_MAKE} vms_test_osx
 
 osx_14_release:
+ <<: *release_only_definition
   <<: *docker_test_definition
   tags:
     - osx_14
--
2.17.1
 
 
 
--
Oleg Piskunov
 
 
 
--
Alexander Tikhonov