Masha,
Thanks, the patch LGTM considering Vlad's remarks and review fix on top.
Please don't forget to squash it with the original patch.
On 13.12.19, Maria wrote:
> It was possible to leak user password through setting 'replication'
> configuration option in first box.cfg invocation. This happened due
> to unconditional logging in load_cfg function. The patch introduces
> conditional logging.
>
> Closes #4493
> ---
> Issue:
>
https://github.com/tarantool/tarantool/issues/4493> Branch:
>
https://github.com/tarantool/tarantool/tree/eljashm/gh-4493-box.cfg-log-may-leak-passwords>
> src/box/lua/load_cfg.lua | 3 +++
> test/box/load_cfg.result | 37 +++++++++++++++++++++++++++++++++++++
> test/box/load_cfg.test.lua | 14 ++++++++++++++
> test/box/lua/cfg_test6.lua | 10 ++++++++++
> 4 files changed, 64 insertions(+)
> create mode 100644 test/box/load_cfg.result
> create mode 100644 test/box/load_cfg.test.lua
> create mode 100644 test/box/lua/cfg_test6.lua
>
<snipped>
> --
> 2.20.1 (Apple Git-117)
>
--
Best regards,
IM