Четверг, 27 февраля 2020, 2:54 +03:00 от Vladislav Shpilevoy <v.shpilevoy@tarantool.org>:
 
Hi! Thanks for the patch!

Please, add a @ChangeLog record.
Hi!
What kind of a changelog should I write?
This is a bug fix with no visible behaviour change (speaking from the users point of view)
--
Serge Petrenko
 

On 26/02/2020 11:00, sergepetrenko wrote:
> https://github.com/tarantool/tarantool/issues/4739
> https://github.com/tarantool/tarantool/tree/sp/gh-4739-vclock-assert-v4
>
> Changes in v4:
> - move row skipping logic from recovery to relay
> - encode a list of instances whose rows to skip
> in SUBSCRIBE request insead of encoding
> is_orhpan status
>
> Changes in v3:
> - review fixes as per review from Vlad
> - instead of skipping rows on replica side,
> do it on master side, by patching recovery
> to silently follow rows coming from a certain
> instance.
>
> Changes in v2:
> - review fixes as per review from Kostja
>
> Serge Petrenko (4):
> box: expose box_is_orphan method
> wal: warn when trying to write a record with a broken lsn
> replication: implement an instance id filter for relay
> replication: do not relay rows coming from a remote instance back to
> it
>
> src/box/applier.cc | 3 ++-
> src/box/box.cc | 13 +++++++++---
> src/box/box.h | 3 +++
> src/box/iproto_constants.h | 1 +
> src/box/relay.cc | 9 ++++++++-
> src/box/relay.h | 3 ++-
> src/box/wal.c | 17 +++++++++++++---
> src/box/xrow.c | 41 +++++++++++++++++++++++++++++++++++---
> src/box/xrow.h | 34 +++++++++++++++++++++----------
> 9 files changed, 101 insertions(+), 23 deletions(-)
>