From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 204CB42F4AD for ; Mon, 15 Jun 2020 18:43:30 +0300 (MSK) From: "Timur Safin" References: In-Reply-To: Date: Mon, 15 Jun 2020 18:43:29 +0300 Message-ID: <157c01d6432b$b79aab70$26d00250$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Tarantool-patches] [PATCH 0/2] ASAN build List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Vladislav Shpilevoy' , tarantool-patches@dev.tarantool.org LGTM : -----Original Message----- : From: Vladislav Shpilevoy : Sent: Sunday, June 14, 2020 7:24 PM : To: tarantool-patches@dev.tarantool.org; tsafin@tarantool.org : Subject: [PATCH 0/2] ASAN build : : The build was broken because sql static library couldn't find some : box symbols, when UB sanitizer was enabled. : : Appeared, that the whole sql library was broken, because there was : a cyclic dependency between box and sql libraries. : : The patch merged sql and box libraries. : : After their merge appeared that some UB sanitations 'woken up' and : started failing, about nullability attributes and usage of NULL : pointers. All of them were false-positive so the second patch : disabled them. : : After this patchset the build works, but the tests don't pass : because of this: : https://github.com/tarantool/tarantool/issues/5078. : : Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5067-asan- : build : Issue: https://github.com/tarantool/tarantool/issues/5067 : Issue: https://github.com/tarantool/tarantool/issues/4609 : : Vladislav Shpilevoy (2): : sql: don't build sql as a separate library : cmake: split UB sanitations into separate flags. : : cmake/compiler.cmake | 44 +++++++++++++-- : src/CMakeLists.txt | 2 +- : src/box/CMakeLists.txt | 101 ++++++++++++++++++++++++++++++++-- : src/box/sql/CMakeLists.txt | 109 ------------------------------------- : 4 files changed, 138 insertions(+), 118 deletions(-) : delete mode 100644 src/box/sql/CMakeLists.txt : : -- : 2.21.1 (Apple Git-122.3)