From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tsafin@tarantool.org>
Received: from smtp1.mail.ru (smtp1.mail.ru [94.100.179.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 6DFA041C5DB
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 15 Jun 2020 18:42:48 +0300 (MSK)
From: "Timur Safin" <tsafin@tarantool.org>
References: <cover.1592151487.git.v.shpilevoy@tarantool.org>
 <6f1f207fe2bfb48531175979d135df25a6f99ef3.1592151487.git.v.shpilevoy@tarantool.org>
In-Reply-To: <6f1f207fe2bfb48531175979d135df25a6f99ef3.1592151487.git.v.shpilevoy@tarantool.org>
Date: Mon, 15 Jun 2020 18:42:47 +0300
Message-ID: <157a01d6432b$9ebeafc0$dc3c0f40$@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH 1/2] sql: don't build sql as a
	separate library
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: 'Vladislav Shpilevoy' <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

Eventually we need to migrate to glob usage (despite to being not 
recommended by cmake authors, it's the only way to maintain 
readable cmakelists for the decently large projects). One day...

LGTM, in any case

:  bin_source(bin_sources bootstrap.snap bootstrap.h)
: 
: +set(sql_sources
: +    sql/opcodes.c
: +    sql/parse.c
: +    sql/alter.c
: +    sql/analyze.c
: +    sql/cursor.c
: +    sql/build.c
: +    sql/callback.c
: +    sql/date.c
: +    sql/delete.c
: +    sql/expr.c
: +    sql/fk_constraint.c
: +    sql/func.c
: +    sql/global.c
: +    sql/hash.c
: +    sql/insert.c
: +    sql/legacy.c
: +    sql/main.c
: +    sql/malloc.c
: +    sql/os.c
: +    sql/os_unix.c
: +    sql/parse_def.c
: +    sql/pragma.c
: +    sql/prepare.c
: +    sql/printf.c
: +    sql/random.c
: +    sql/resolve.c
: +    sql/select.c
: +    sql/tokenize.c
: +    sql/treeview.c
: +    sql/trigger.c
: +    sql/utf.c
: +    sql/update.c
: +    sql/util.c
: +    sql/vdbe.c
: +    sql/vdbeapi.c
: +    sql/vdbeaux.c
: +    sql/vdbemem.c
: +    sql/vdbesort.c
: +    sql/vdbetrace.c
: +    sql/walker.c
: +    sql/where.c
: +    sql/wherecode.c
: +    sql/whereexpr.c
: +)
: +
:  add_custom_target(box_generate_lua_sources
:      WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/src/box
:      DEPENDS ${lua_sources})