Sasha,

Thanks, you've fixed almost everything. Sorry, two my remarks were
slightly misleading, thus I extended them in the corresponding patch
in this patchset. Please consider them, since everything else LGTM.

I guess after the final fixes you can squash everithing into a single
commit and ask Sasha Tu to proceed with the patch.

On 13.01.20, Alexander V. Tikhonov wrote:

> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-3380-push-packages-s3-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/3380
>
> v4: https://lists.tarantool.org/pipermail/tarantool-patches/2020-January/013568.html
> v3: https://lists.tarantool.org/pipermail/tarantool-patches/2019-December/013060.html
> v2: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012352.html
> v1: https://lists.tarantool.org/pipermail/tarantool-patches/2019-October/012021.html
>
> Changes v4:
> - minor corrections
>
> Changes v3:
> - common code parts merged to standalone routines
> - corrected code style, minor updates
> - script is ready for release
>
> Changes v2:
> - made changes in script from draft to pre-release stages
>
> Alexander V. Tikhonov (3):
> gitlab-ci: implement packing into MCS S3
> Testing changes after 2nd review on S3
> Testing changes after 3rd review on S3
>
> .gitlab-ci.yml | 5 +-
> .gitlab.mk | 20 +-
> .travis.mk | 41 ++-
> tools/add_pack_s3_repo.sh | 527 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 567 insertions(+), 26 deletions(-)
> create mode 100755 tools/add_pack_s3_repo.sh
>
> --
> 2.17.1
>

--
Best regards,
IM