Mergen,

Thanks for your fast patch, for me it looks correct and testing passed too, so LGTM.


Четверг, 19 декабря 2019, 17:56 +03:00 от imeevma@tarantool.org:

---
https://github.com/tarantool/tarantool/tree/imeevma/gh-4672-fix-test-for-1.10

 test/box/gh-4672-min-integer-value-in-serializer.result | 8 ++++----
 test/box/gh-4672-min-integer-value-in-serializer.test.lua | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/test/box/gh-4672-min-integer-value-in-serializer.result b/test/box/gh-4672-min-integer-value-in-serializer.result
index f4d7adb..a9540d9 100644
--- a/test/box/gh-4672-min-integer-value-in-serializer.result
+++ b/test/box/gh-4672-min-integer-value-in-serializer.result
@@ -36,7 +36,7 @@ s:insert({3, 0})
  | ---
  | - [3, 0]
  | ...
-s:update(3, {{'=', 'i', -2^63}})
+s:update(3, {{'=', 2, -2^63}})
  | ---
  | - [3, -9223372036854775808]
  | ...
@@ -44,7 +44,7 @@ s:insert({4, 0})
  | ---
  | - [4, 0]
  | ...
-s:update(4, {{'=', 'i', -9223372036854775808LL}})
+s:update(4, {{'=', 2, -9223372036854775808LL}})
  | ---
  | - [4, -9223372036854775808]
  | ...
@@ -72,7 +72,7 @@ s:insert({13, 0})
  | ---
  | - [13, 0]
  | ...
-s:update(13, {{'=', 'i', -2^63}})
+s:update(13, {{'=', 2, -2^63}})
  | ---
  | - [13, -9223372036854775808]
  | ...
@@ -80,7 +80,7 @@ s:insert({14, 0})
  | ---
  | - [14, 0]
  | ...
-s:update(14, {{'=', 'i', -9223372036854775808LL}})
+s:update(14, {{'=', 2, -9223372036854775808LL}})
  | ---
  | - [14, -9223372036854775808]
  | ...
diff --git a/test/box/gh-4672-min-integer-value-in-serializer.test.lua b/test/box/gh-4672-min-integer-value-in-serializer.test.lua
index f718a56..fcabb3a 100644
--- a/test/box/gh-4672-min-integer-value-in-serializer.test.lua
+++ b/test/box/gh-4672-min-integer-value-in-serializer.test.lua
@@ -14,9 +14,9 @@ _ = s:create_index('ii')
 s:insert({1, -2^63})
 s:insert({2, -9223372036854775808LL})
 s:insert({3, 0})
-s:update(3, {{'=', 'i', -2^63}})
+s:update(3, {{'=', 2, -2^63}})
 s:insert({4, 0})
-s:update(4, {{'=', 'i', -9223372036854775808LL}})
+s:update(4, {{'=', 2, -9223372036854775808LL}})
 
 box.schema.user.grant('guest', 'read, write', 'space', 'serializer_test_space')
 
@@ -26,9 +26,9 @@ s = cn.space.serializer_test_space
 s:insert({11, -2^63})
 s:insert({12, -9223372036854775808LL})
 s:insert({13, 0})
-s:update(13, {{'=', 'i', -2^63}})
+s:update(13, {{'=', 2, -2^63}})
 s:insert({14, 0})
-s:update(14, {{'=', 'i', -9223372036854775808LL}})
+s:update(14, {{'=', 2, -9223372036854775808LL}})
 
 cn:close()
 box.schema.user.revoke('guest', 'read, write', 'space', 'serializer_test_space')
--
2.7.4



--
Alexander Tikhonov