Igor, thanks for the review, I've made changes as you asked for. >Среда, 18 декабря 2019, 19:03 +03:00 от Igor Munkin : > >Sasha, > >Thanks for the patchset, I left several comments per patch, however in >the first one I wrote a general one, but I think it's convenient to left >it here too. > >I guess it's preferable to have a sole 'build:' tag for any patch >related to the build system. Feel free to ignore and proceed if >Sasha Tu. (he's already CCed as a second reviewer) has no remarks to the >subj. > >On 10.12.19, Alexander V. Tikhonov wrote: >> Made the following changes at Dockerfile for static build: >> - changed 'wget' tool use to 'curl -O -L' to avoid of '500' HTTP >> error respond from download servers >> - changed the link from sourceforge to github to download >> the icu4c sources, as suggested on icu4c web site >> - added 'build' directory removement to avoid of old configuration >> at build/curl which is used for curl building >> - removed LD_LIBRARY_PATH environment from curl build, due to the >> path is empty in real and is not needed >> - added '-j' option to make tool calls for all builds to speed it up >> in 4 times >> - set Dockerfile WORKDIR from the very start of Tarantool sources >> builds to make the Dockerfile code more readable and removed all >> duplicating calls to Tarantool sources directory changes. >> >> Github: https://github.com/tarantool/tarantool/tree/avtikhon/dockerfile-static-build-full-ci >> Issue: - >> >> Alexander V. Tikhonov (5): >> static build: speedup build >> static build: remove unneeded LD_LIBRARY_PATH >> static build: cleanup Dockerfile >> static build: added build subdirectory cleanup >> static build: resolve issues with sourceforge.net >> >> Dockerfile.staticbuild | 37 +++++++++++++++++-------------------- >> 1 file changed, 17 insertions(+), 20 deletions(-) >> >> -- >> 2.17.1 >> > >-- >Best regards, >IM -- Alexander Tikhonov