Hi!

Thanks for your review.

Sent v3 of the patchset considering mentioned drawbacks.


Воскресенье, 24 ноября 2019, 18:53 +03:00 от Vladislav Shpilevoy <v.shpilevoy@tarantool.org>:

Hi!

Please, specify branch and issue links.

Issue: https://github.com/tarantool/tarantool/issues/4586
Branch: https://github.com/tarantool/tarantool/commits/i.kosarev/gh-4586-fix-quorum-test

Add 'Changes in V2' section, when you send a new version.

On 23/11/2019 22:53, Ilya Kosarev wrote:
> This patchset fixes appliers pruning in replicaset_update, anon
> replicas iteration issues in replicaset_follow and stabilizes quorum
> test. It also stabilizes tcp_connect in test_run:cmd().
>
> Ilya Kosarev (4):
> test: update test-run
> replication: fix appliers pruning
> replication: make anon replicas iteration safe
> test: stabilize quorum test conditions
>
> src/box/replication.cc | 17 +++---
> test-run | 2 +-
> .../box_set_replication_stress.result | 38 +++++++++++++
> .../box_set_replication_stress.test.lua | 17 ++++++
> test/replication/quorum.result | 54 ++++++++++++++-----
> test/replication/quorum.test.lua | 24 +++++----
> 6 files changed, 121 insertions(+), 31 deletions(-)
> create mode 100644 test/replication/box_set_replication_stress.result
> create mode 100644 test/replication/box_set_replication_stress.test.lua
>


--
Ilya Kosarev