Hi! Thanks for your review. Sent fixed patch in reply to this message: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012195.html   >Четверг, 31 октября 2019, 1:16 +03:00 от Vladislav Shpilevoy : > >Hi! Thanks for the patch! > >LGTM, except the comment below. > >> diff --git a/src/box/wal.h b/src/box/wal.h >> index b76b0a41f..827b0fb85 100644 >> --- a/src/box/wal.h >> +++ b/src/box/wal.h >> @@ -182,9 +182,10 @@ wal_mode(); >> /** >> * Wait until all submitted writes are successfully flushed >> * to disk. Returns 0 on success, -1 if write failed. >> + * Corresponding vclock is returned in @vclock unless it is NULL. >> */ >For parameter reference, please, use '@a ' syntax, >not '@'. See doxygen documentation on @a. > >> int >> -wal_sync(void); >> +wal_sync(struct vclock *vclock); >> -- Ilya Kosarev