I'm not quiet happy of cleanup roll back, but anyway I did it for all places that were changed by it, in places where the code was deleted I've left it, as it doesn't change the history of the code.

           Alexander


Пятница, 16 августа 2019, 5:32 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:

I looked briefly and it seems to be okay. But, please, remove cleanup
changes from the dockerfile: they hide real changes and bloats the
patch.

I'll look deeper when you'll update the patch.

WBR, Alexander Turenko.

> -RUN set -x \
> - && yum -y install \
> +RUN set -x && \
> + yum -y install \

I meant this kind of changes.

> -RUN yum -y install ncurses-static readline-static zlib-static pcre-static glibc-static
> + yum -y install \
> + ncurses-static \
> + readline-static \
> + zlib-static \
> + pcre-static \
> + glibc-static && \
> + yum -y install \
> + python-devel \
> + python-pip

This.

> +WORKDIR /
>
> RUN set -x && \
> - cd / && \
> curl -O -L https://www.openssl.org/source/openssl-1.1.0h.tar.gz && \
> tar -xvf openssl-1.1.0h.tar.gz && \
> cd openssl-1.1.0h && \

And this.



--
Alexander Tikhonov