Hi!


Вторник, 23 июля 2019, 12:40 +03:00 от Alexander Turenko <alexander.turenko@tarantool.org>:

> I addressed this issue in a patch to tarantool/libyaml. Please check it out.
> This patch remains intact.

Okay. I don't have objections, but one comment.

> >> - set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w")
> >> + set_target_properties(yaml PROPERTIES COMPILE_FLAGS "-w -std=c99")

Maybe it worth to declare a loop variable outside a loop initialization
statement in libyaml (and update the upstream PR)? I mean that if all
libyaml code follow C89, then we maybe should do it too in our changes.
What do you think?

This seems reasonable.
I updated both branches
(https://github.com/tarantool/libyaml/tree/sp/static-linking and 
https://github.com/tarantool/tarantool/tree/sp/gh-4090-enable-bundled-libyaml-full-ci)
I've also updated the pull request to libyaml upstream.





--
Sergey Petrenko