From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5EF194696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sat,  4 Apr 2020 02:42:47 +0300 (MSK)
References: <cover.1584110394.git.k.sosnin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <15594780-32ed-abf0-5c39-9b0c7d9438c5@tarantool.org>
Date: Sat, 4 Apr 2020 01:42:45 +0200
MIME-Version: 1.0
In-Reply-To: <cover.1584110394.git.k.sosnin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] box: fix session.push
	formatting
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the fixes!

The patchset LGTM. Except that the changelog is still
missing.

Please, add a changelog, and send on a second review.
I propose either Nikita or Alexander L.

On 13/03/2020 15:58, Chris Sosnin wrote:
> issue: https://github.com/tarantool/tarantool/issues/4686
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4686-session-push-fmt
> 
> Changes in v2:
>  - Current format moved to struct session.
>  - Applied review fixes.
> 
> Chris Sosnin (2):
>   refactoring: store output format in struct session
>   box: fix formatting in session.push
> 
>  extra/exports                 |  2 +
>  src/box/lua/console.c         | 53 ++++++++++++++++++--------
>  src/box/lua/console.lua       | 72 +++++++++++++++++++++++++++--------
>  src/box/session.h             | 22 ++++++++---
>  test/app-tap/console.test.lua | 14 ++++++-
>  5 files changed, 126 insertions(+), 37 deletions(-)
>