From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 334CB469711
 for <tarantool-patches@dev.tarantool.org>;
 Sat,  6 Jun 2020 21:02:54 +0300 (MSK)
References: <cover.1591259297.git.sergeyb@tarantool.org>
 <ebc4456b6256976f1112483b642705bd2a0f5ff6.1591259297.git.sergeyb@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <155870bb-df1c-fb89-868c-29c3321c992b@tarantool.org>
Date: Sat, 6 Jun 2020 20:02:51 +0200
MIME-Version: 1.0
In-Reply-To: <ebc4456b6256976f1112483b642705bd2a0f5ff6.1591259297.git.sergeyb@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 4/6] Fix luacheck warnings in
 extra/dist/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org, imun@tarantool.org
Cc: alexander.turenko@tarantool.org

Thanks for the patch!

On 04/06/2020 10:39, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Part of #4681
> 
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Reviewed-by: Igor Munkin <imun@tarantool.org>
> 
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Co-authored-by: Igor Munkin <imun@tarantool.org>
> ---
>  .luacheckrc                | 15 ++++++++++++++-
>  extra/dist/tarantoolctl.in | 25 +++++++------------------
>  2 files changed, 21 insertions(+), 19 deletions(-)
> 
> diff --git a/.luacheckrc b/.luacheckrc
> index e6edf8617..b917eb927 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -1,12 +1,19 @@
>  std = "luajit"
> +globals = {"box", "_TARANTOOL"}
> +ignore = {
> +    "212/self", -- Unused argument <self>.
> +    "411",      -- Redefining a local variable.
> +    "431",      -- Shadowing an upvalue.
> +}
> +

Unnecessary empty line after }.