From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A06C46ECC0; Wed, 8 Dec 2021 14:57:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A06C46ECC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1638964622; bh=N9clsQWmtd9Bwd3Ln+J0axKhhXyOb9+QKYDV6B1Medw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AzcHTEB6QbqzB6bGJNxcnTDgWY91vnMykxCcXh8jy/dAiqnvs4tp0LMLaUrfq6nZY jk+NLkDRlAAJp3sTZGeJTW8Q/rwLz6xBtt4Y3WrOY6Ckcw2dpOHAB7nKZuaoY+gewC vriYq176VDoH6BIjZipTyU0MHMaqoGUVCir3LGTM= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4FEE06ECC0 for ; Wed, 8 Dec 2021 14:57:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4FEE06ECC0 Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1muvZD-0006N0-E5; Wed, 08 Dec 2021 14:56:59 +0300 Message-ID: <154ac6e5-0588-9209-47bb-9f15f3aaeb29@tarantool.org> Date: Wed, 8 Dec 2021 14:56:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Content-Language: en-GB To: Vladimir Davydov Cc: Serge Petrenko via Tarantool-patches References: <20211208104454.20345-1-sergepetrenko@tarantool.org> <20211208110050.ntfyrjifksrw5hw4@esperanza> <5169d323-4c8f-d7d2-3344-32fcad5c2d5d@tarantool.org> <20211208112554.xdyltiuxuqfzqu4x@esperanza> In-Reply-To: <20211208112554.xdyltiuxuqfzqu4x@esperanza> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD99F281DB1F96F126D6E5EB0A4CDE28CAC978635DA31B4F53D00894C459B0CD1B9D73A82D60F87C65122414541BCEC317E2683E051691FC859ECA116FACD37B17E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77BF46084C0059042EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BB46061768088B55EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F25FD0EA225E0E7418098C0F3C8AF8F586CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D2DCF9CF1F528DBCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CDBD4EED10340066BC0837EA9F3D197644AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3318E5214BBCD6382BA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE76D0F27F7E6A6C418731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A515B9F657122908C492A0AEAD2C292B6F702B5B98461F53C6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA755C623DA9A0966939410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AAC3D1FDB34D048859EC842FFF65460EDCCF3F90B1F846E823822C6E783F817E28E1A2AB1E50429A1D7E09C32AA3244CC798AC98D8B4AC593D31D8D5B6EAF71C05AB220A9D022EBC729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnkZtajpA89XxZdfh+PvBKA== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE407519E1B86C100A031B3E793ECCE5C8C7C3914585B673D25D96BB2E709EA627F343C7DDD459B58856F0E45BC603594F5A135B915D4279FF0574198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] replication: fix flaky gh-3160-misc... test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 08.12.2021 14:25, Vladimir Davydov пишет: > On Wed, Dec 08, 2021 at 02:13:04PM +0300, Serge Petrenko wrote: >> >> 08.12.2021 14:00, Vladimir Davydov via Tarantool-patches пишет: >>> Merged into master, 2.8, 1.10. >>> >>> Please don't send emails. PR is enough :-) >> Some people prefer emails over PRs. >> >> I think everyone should review the patches where it suits >> them best, so I open PRs for you and send emails to Vlad. >> (even though this is double the hustle). > This is confusing. I noticed the email only after I merged the PR. > In the PR, I was the only reviewer so I reckoned it's okay to merge, > but it turned out the patch was also sent to Vlad via email... Yes, that's my bad. I could've put Vlad into reviewers list as well. > > Also, when the same patch is reviewed both via email and PR, the same > comment might be raised twice by different reviewers or reviewers may > suggest different things being not aware of each other's arguments and > you'll have to reconcile. I agree. Though this particular patch was rather small, so I don't think it could raise any disputes. > > Vlad can review patches in PRs AFAICS - he reviews my patches in PRs, > for instance. -- Serge Petrenko